Commit 19a7aff8 authored by Florian Fainelli's avatar Florian Fainelli Committed by Greg Kroah-Hartman

cpmac: do not leak struct net_device on phy_connect errors

commit ed770f01 upstream.

If the call to phy_connect fails, we will return directly instead of freeing
the previously allocated struct net_device.
Signed-off-by: default avatarFlorian Fainelli <florian@openwrt.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent eb6c5150
...@@ -1176,7 +1176,8 @@ static int __devinit cpmac_probe(struct platform_device *pdev) ...@@ -1176,7 +1176,8 @@ static int __devinit cpmac_probe(struct platform_device *pdev)
if (netif_msg_drv(priv)) if (netif_msg_drv(priv))
printk(KERN_ERR "%s: Could not attach to PHY\n", printk(KERN_ERR "%s: Could not attach to PHY\n",
dev->name); dev->name);
return PTR_ERR(priv->phy); rc = PTR_ERR(priv->phy);
goto fail;
} }
if ((rc = register_netdev(dev))) { if ((rc = register_netdev(dev))) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment