Commit 19bb2227 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Wolfram Sang

i2c: mux: pca954x: Refactor pca954x_irq_handler()

Refactor pca954x_irq_handler() to:
  - use for_each_set_bit() macro
  - use IRQ_RETVAL() macro

Above change makes code easy to read and understand.
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarPeter Rosin <peda@axentia.se>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent 73371d5f
...@@ -327,21 +327,18 @@ static DEVICE_ATTR_RW(idle_state); ...@@ -327,21 +327,18 @@ static DEVICE_ATTR_RW(idle_state);
static irqreturn_t pca954x_irq_handler(int irq, void *dev_id) static irqreturn_t pca954x_irq_handler(int irq, void *dev_id)
{ {
struct pca954x *data = dev_id; struct pca954x *data = dev_id;
unsigned int child_irq; unsigned long pending;
int ret, i, handled = 0; int ret, i;
ret = i2c_smbus_read_byte(data->client); ret = i2c_smbus_read_byte(data->client);
if (ret < 0) if (ret < 0)
return IRQ_NONE; return IRQ_NONE;
for (i = 0; i < data->chip->nchans; i++) { pending = (ret >> PCA954X_IRQ_OFFSET) & (BIT(data->chip->nchans) - 1);
if (ret & BIT(PCA954X_IRQ_OFFSET + i)) { for_each_set_bit(i, &pending, data->chip->nchans)
child_irq = irq_linear_revmap(data->irq, i); handle_nested_irq(irq_linear_revmap(data->irq, i));
handle_nested_irq(child_irq);
handled++; return IRQ_RETVAL(pending);
}
}
return handled ? IRQ_HANDLED : IRQ_NONE;
} }
static int pca954x_irq_set_type(struct irq_data *idata, unsigned int type) static int pca954x_irq_set_type(struct irq_data *idata, unsigned int type)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment