Commit 1a3ccc9f authored by Anton Altaparmakov's avatar Anton Altaparmakov

NTFS: Fix stupid bug in fs/ntfs/attrib.c::ntfs_attr_reinit_search_ctx() where

      we did not clear ctx->al_entry but it was still set due to changes in
      ntfs_attr_lookup() and ntfs_external_attr_find() in particular.
Signed-off-by: default avatarAnton Altaparmakov <aia21@cantab.net>
parent d5978a21
...@@ -277,6 +277,8 @@ ChangeLog ...@@ -277,6 +277,8 @@ ChangeLog
Note, a technical ChangeLog aimed at kernel hackers is in fs/ntfs/ChangeLog. Note, a technical ChangeLog aimed at kernel hackers is in fs/ntfs/ChangeLog.
2.1.20:
- Fix a stupid bug introduced in 2.1.18 release.
2.1.19: 2.1.19:
- Minor bugfix in handling of the default upcase table. - Minor bugfix in handling of the default upcase table.
- Many internal cleanups and improvements. Many thanks to Linus - Many internal cleanups and improvements. Many thanks to Linus
......
...@@ -21,6 +21,13 @@ ToDo/Notes: ...@@ -21,6 +21,13 @@ ToDo/Notes:
- Enable the code for setting the NT4 compatibility flag when we start - Enable the code for setting the NT4 compatibility flag when we start
making NTFS 1.2 specific modifications. making NTFS 1.2 specific modifications.
2.1.20 - Fix a stupid bug in ntfs_attr_reinit_search_ctx().
- Fix stupid bug in fs/ntfs/attrib.c::ntfs_attr_reinit_search_ctx()
where we did not clear ctx->al_entry but it was still set due to
changes in ntfs_attr_lookup() and ntfs_external_attr_find() in
particular.
2.1.19 - Many cleanups, improvements, and a minor bug fix. 2.1.19 - Many cleanups, improvements, and a minor bug fix.
- Update ->setattr (fs/ntfs/inode.c::ntfs_setattr()) to refuse to - Update ->setattr (fs/ntfs/inode.c::ntfs_setattr()) to refuse to
......
...@@ -6,7 +6,7 @@ ntfs-objs := aops.o attrib.o collate.o compress.o debug.o dir.o file.o \ ...@@ -6,7 +6,7 @@ ntfs-objs := aops.o attrib.o collate.o compress.o debug.o dir.o file.o \
index.o inode.o mft.o mst.o namei.o super.o sysctl.o unistr.o \ index.o inode.o mft.o mst.o namei.o super.o sysctl.o unistr.o \
upcase.o upcase.o
EXTRA_CFLAGS = -DNTFS_VERSION=\"2.1.19\" EXTRA_CFLAGS = -DNTFS_VERSION=\"2.1.20\"
ifeq ($(CONFIG_NTFS_DEBUG),y) ifeq ($(CONFIG_NTFS_DEBUG),y)
EXTRA_CFLAGS += -DDEBUG EXTRA_CFLAGS += -DDEBUG
......
...@@ -1861,6 +1861,11 @@ void ntfs_attr_reinit_search_ctx(ntfs_attr_search_ctx *ctx) ...@@ -1861,6 +1861,11 @@ void ntfs_attr_reinit_search_ctx(ntfs_attr_search_ctx *ctx)
/* Sanity checks are performed elsewhere. */ /* Sanity checks are performed elsewhere. */
ctx->attr = (ATTR_RECORD*)((u8*)ctx->mrec + ctx->attr = (ATTR_RECORD*)((u8*)ctx->mrec +
le16_to_cpu(ctx->mrec->attrs_offset)); le16_to_cpu(ctx->mrec->attrs_offset));
/*
* This needs resetting due to ntfs_external_attr_find() which
* can leave it set despite having zeroed ctx->base_ntfs_ino.
*/
ctx->al_entry = NULL;
return; return;
} /* Attribute list. */ } /* Attribute list. */
if (ctx->ntfs_ino != ctx->base_ntfs_ino) if (ctx->ntfs_ino != ctx->base_ntfs_ino)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment