Commit 1a6dd999 authored by Vincent Mailhol's avatar Vincent Mailhol Committed by Marc Kleine-Budde

can: mcp251xfd: silence clang's -Wunaligned-access warning

clang emits a -Wunaligned-access warning on union
mcp251xfd_tx_ojb_load_buf.

The reason is that field hw_tx_obj (not declared as packed) is being
packed right after a 16 bits field inside a packed struct:

| union mcp251xfd_tx_obj_load_buf {
| 	struct __packed {
| 		struct mcp251xfd_buf_cmd cmd;
| 		  /* ^ 16 bits fields */
| 		struct mcp251xfd_hw_tx_obj_raw hw_tx_obj;
| 		  /* ^ not declared as packed */
| 	} nocrc;
| 	struct __packed {
| 		struct mcp251xfd_buf_cmd_crc cmd;
| 		struct mcp251xfd_hw_tx_obj_raw hw_tx_obj;
| 		__be16 crc;
| 	} crc;
| } ____cacheline_aligned;

Starting from LLVM 14, having an unpacked struct nested in a packed
struct triggers a warning. c.f. [1].

This is a false positive because the field is always being accessed
with the relevant put_unaligned_*() function. Adding __packed to the
structure declaration silences the warning.

[1] https://github.com/llvm/llvm-project/issues/55520

Link: https://lore.kernel.org/all/20220518114357.55452-1-mailhol.vincent@wanadoo.frSigned-off-by: default avatarVincent Mailhol <mailhol.vincent@wanadoo.fr>
Reported-by: default avatarkernel test robot <lkp@intel.com>
Tested-by: Nathan Chancellor <nathan@kernel.org> # build
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 6c1e423a
...@@ -441,7 +441,7 @@ struct mcp251xfd_hw_tef_obj { ...@@ -441,7 +441,7 @@ struct mcp251xfd_hw_tef_obj {
/* The tx_obj_raw version is used in spi async, i.e. without /* The tx_obj_raw version is used in spi async, i.e. without
* regmap. We have to take care of endianness ourselves. * regmap. We have to take care of endianness ourselves.
*/ */
struct mcp251xfd_hw_tx_obj_raw { struct __packed mcp251xfd_hw_tx_obj_raw {
__le32 id; __le32 id;
__le32 flags; __le32 flags;
u8 data[sizeof_field(struct canfd_frame, data)]; u8 data[sizeof_field(struct canfd_frame, data)];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment