Commit 1a92f989 authored by Bibby Hsieh's avatar Bibby Hsieh Committed by Matthias Brugger

soc: mediatek: cmdq: reorder the parameter

The order of gce instructions is [subsys offset value]
so reorder the parameter of cmdq_pkt_write_mask
and cmdq_pkt_write function.
Signed-off-by: default avatarBibby Hsieh <bibby.hsieh@mediatek.com>
Reviewed-by: default avatarCK Hu <ck.hu@mediatek.com>
Signed-off-by: default avatarMatthias Brugger <matthias.bgg@gmail.com>
parent 5f9e832c
...@@ -136,7 +136,7 @@ static int cmdq_pkt_append_command(struct cmdq_pkt *pkt, enum cmdq_code code, ...@@ -136,7 +136,7 @@ static int cmdq_pkt_append_command(struct cmdq_pkt *pkt, enum cmdq_code code,
return 0; return 0;
} }
int cmdq_pkt_write(struct cmdq_pkt *pkt, u32 value, u32 subsys, u32 offset) int cmdq_pkt_write(struct cmdq_pkt *pkt, u32 subsys, u32 offset, u32 value)
{ {
u32 arg_a = (offset & CMDQ_ARG_A_WRITE_MASK) | u32 arg_a = (offset & CMDQ_ARG_A_WRITE_MASK) |
(subsys << CMDQ_SUBSYS_SHIFT); (subsys << CMDQ_SUBSYS_SHIFT);
...@@ -145,8 +145,8 @@ int cmdq_pkt_write(struct cmdq_pkt *pkt, u32 value, u32 subsys, u32 offset) ...@@ -145,8 +145,8 @@ int cmdq_pkt_write(struct cmdq_pkt *pkt, u32 value, u32 subsys, u32 offset)
} }
EXPORT_SYMBOL(cmdq_pkt_write); EXPORT_SYMBOL(cmdq_pkt_write);
int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u32 value, int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u32 subsys,
u32 subsys, u32 offset, u32 mask) u32 offset, u32 value, u32 mask)
{ {
u32 offset_mask = offset; u32 offset_mask = offset;
int err = 0; int err = 0;
......
...@@ -63,26 +63,26 @@ void cmdq_pkt_destroy(struct cmdq_pkt *pkt); ...@@ -63,26 +63,26 @@ void cmdq_pkt_destroy(struct cmdq_pkt *pkt);
/** /**
* cmdq_pkt_write() - append write command to the CMDQ packet * cmdq_pkt_write() - append write command to the CMDQ packet
* @pkt: the CMDQ packet * @pkt: the CMDQ packet
* @value: the specified target register value
* @subsys: the CMDQ sub system code * @subsys: the CMDQ sub system code
* @offset: register offset from CMDQ sub system * @offset: register offset from CMDQ sub system
* @value: the specified target register value
* *
* Return: 0 for success; else the error code is returned * Return: 0 for success; else the error code is returned
*/ */
int cmdq_pkt_write(struct cmdq_pkt *pkt, u32 value, u32 subsys, u32 offset); int cmdq_pkt_write(struct cmdq_pkt *pkt, u32 subsys, u32 offset, u32 value);
/** /**
* cmdq_pkt_write_mask() - append write command with mask to the CMDQ packet * cmdq_pkt_write_mask() - append write command with mask to the CMDQ packet
* @pkt: the CMDQ packet * @pkt: the CMDQ packet
* @value: the specified target register value
* @subsys: the CMDQ sub system code * @subsys: the CMDQ sub system code
* @offset: register offset from CMDQ sub system * @offset: register offset from CMDQ sub system
* @value: the specified target register value
* @mask: the specified target register mask * @mask: the specified target register mask
* *
* Return: 0 for success; else the error code is returned * Return: 0 for success; else the error code is returned
*/ */
int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u32 value, int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u32 subsys,
u32 subsys, u32 offset, u32 mask); u32 offset, u32 value, u32 mask);
/** /**
* cmdq_pkt_wfe() - append wait for event command to the CMDQ packet * cmdq_pkt_wfe() - append wait for event command to the CMDQ packet
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment