Commit 1ae5ccc7 authored by Mark Bloch's avatar Mark Bloch Committed by Doug Ledford

IB/core: Remove unnecessary check in ibnl_rcv_msg

RDMA_NL_GET_OP is defined like this: (type & ((1 << 10) - 1))
which means op (defined as an int) can never be a negative number.

Fixes: b2cbae2c ('RDMA: Add netlink infrastructure')
Signed-off-by: default avatarMark Bloch <markb@mellanox.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 5ed935e8
...@@ -151,12 +151,11 @@ static int ibnl_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh) ...@@ -151,12 +151,11 @@ static int ibnl_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
struct ibnl_client *client; struct ibnl_client *client;
int type = nlh->nlmsg_type; int type = nlh->nlmsg_type;
int index = RDMA_NL_GET_CLIENT(type); int index = RDMA_NL_GET_CLIENT(type);
int op = RDMA_NL_GET_OP(type); unsigned int op = RDMA_NL_GET_OP(type);
list_for_each_entry(client, &client_list, list) { list_for_each_entry(client, &client_list, list) {
if (client->index == index) { if (client->index == index) {
if (op < 0 || op >= client->nops || if (op >= client->nops || !client->cb_table[op].dump)
!client->cb_table[op].dump)
return -EINVAL; return -EINVAL;
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment