Commit 1b28c3e6 authored by Dave Airlie's avatar Dave Airlie

drm/qxl: fix memory leak in release list handling

wow no idea how I got this far without seeing this,
leaking the entries in the list makes kmalloc-64 slab grow.

References: https://bugzilla.kernel.org/show_bug.cgi?id=65121
Cc: stable@vger.kernel.org
Reported-by: default avatarMatthew Stapleton <matthew4196@gmail.com>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent eec99016
...@@ -92,6 +92,7 @@ qxl_release_free(struct qxl_device *qdev, ...@@ -92,6 +92,7 @@ qxl_release_free(struct qxl_device *qdev,
- DRM_FILE_OFFSET); - DRM_FILE_OFFSET);
qxl_fence_remove_release(&bo->fence, release->id); qxl_fence_remove_release(&bo->fence, release->id);
qxl_bo_unref(&bo); qxl_bo_unref(&bo);
kfree(entry);
} }
spin_lock(&qdev->release_idr_lock); spin_lock(&qdev->release_idr_lock);
idr_remove(&qdev->release_idr, release->id); idr_remove(&qdev->release_idr, release->id);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment