Commit 1b2ca422 authored by Borislav Petkov's avatar Borislav Petkov Committed by Gleb Natapov

kvm, cpuid: Fix sparse warning

We need to copy padding to kernel space first before looking at it.
Reported-by: default avatarkbuild test robot <fengguang.wu@intel.com>
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Signed-off-by: default avatarGleb Natapov <gleb@redhat.com>
parent a890b6fe
...@@ -564,6 +564,7 @@ static bool sanity_check_entries(struct kvm_cpuid_entry2 __user *entries, ...@@ -564,6 +564,7 @@ static bool sanity_check_entries(struct kvm_cpuid_entry2 __user *entries,
__u32 num_entries, unsigned int ioctl_type) __u32 num_entries, unsigned int ioctl_type)
{ {
int i; int i;
__u32 pad[3];
if (ioctl_type != KVM_GET_EMULATED_CPUID) if (ioctl_type != KVM_GET_EMULATED_CPUID)
return false; return false;
...@@ -577,9 +578,10 @@ static bool sanity_check_entries(struct kvm_cpuid_entry2 __user *entries, ...@@ -577,9 +578,10 @@ static bool sanity_check_entries(struct kvm_cpuid_entry2 __user *entries,
* sheds a tear. * sheds a tear.
*/ */
for (i = 0; i < num_entries; i++) { for (i = 0; i < num_entries; i++) {
if (entries[i].padding[0] || if (copy_from_user(pad, entries[i].padding, sizeof(pad)))
entries[i].padding[1] || return true;
entries[i].padding[2])
if (pad[0] || pad[1] || pad[2])
return true; return true;
} }
return false; return false;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment