Commit 1b5853df authored by Javier Martinez Canillas's avatar Javier Martinez Canillas Committed by Lucas De Marchi

fbdev: efifb: Fix a use-after-free due early fb_info cleanup

Commit d258d00f ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather
than .remove") attempted to fix a use-after-free error due driver freeing
the fb_info in the .remove handler instead of doing it in .fb_destroy.

But ironically that change introduced yet another use-after-free since the
fb_info was still used after the free.

This should fix for good by freeing the fb_info at the end of the handler.

Fixes: d258d00f ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove")
Reported-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Reported-by: default avatarAndrzej Hajda <andrzej.hajda@intel.com>
Signed-off-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Reviewed-by: default avatarAndi Shyti <andi.shyti@linux.intel.com>
Reviewed-by: default avatarAndrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: default avatarThomas Zimmermann <tzimemrmann@suse.de>
Signed-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220506132225.588379-1-javierm@redhat.com
parent ab244be4
...@@ -259,12 +259,12 @@ static void efifb_destroy(struct fb_info *info) ...@@ -259,12 +259,12 @@ static void efifb_destroy(struct fb_info *info)
memunmap(info->screen_base); memunmap(info->screen_base);
} }
framebuffer_release(info);
if (request_mem_succeeded) if (request_mem_succeeded)
release_mem_region(info->apertures->ranges[0].base, release_mem_region(info->apertures->ranges[0].base,
info->apertures->ranges[0].size); info->apertures->ranges[0].size);
fb_dealloc_cmap(&info->cmap); fb_dealloc_cmap(&info->cmap);
framebuffer_release(info);
} }
static const struct fb_ops efifb_ops = { static const struct fb_ops efifb_ops = {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment