Commit 1c0e3c73 authored by Jules Irenge's avatar Jules Irenge Committed by Kalle Valo

hostap: Add missing annotations for prism2_bss_list_proc_start() and prism2_bss_list_proc_stop

Sparse reports warnings at prism2_bss_list_proc_start() and prism2_bss_list_proc_stop()

warning: context imbalance in prism2_wds_proc_stop() - unexpected unlock
warning: context imbalance in prism2_bss_list_proc_start() - wrong count at exit

The root cause is the missing annotations at prism2_bss_list_proc_start()

Add the missing __acquires(&local->lock) annotation
Add the missing __releases(&local->lock) annotation
Signed-off-by: default avatarJules Irenge <jbi.octave@gmail.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200411001933.10072-4-jbi.octave@gmail.com
parent 297bcf82
...@@ -149,6 +149,7 @@ static int prism2_bss_list_proc_show(struct seq_file *m, void *v) ...@@ -149,6 +149,7 @@ static int prism2_bss_list_proc_show(struct seq_file *m, void *v)
} }
static void *prism2_bss_list_proc_start(struct seq_file *m, loff_t *_pos) static void *prism2_bss_list_proc_start(struct seq_file *m, loff_t *_pos)
__acquires(&local->lock)
{ {
local_info_t *local = PDE_DATA(file_inode(m->file)); local_info_t *local = PDE_DATA(file_inode(m->file));
spin_lock_bh(&local->lock); spin_lock_bh(&local->lock);
...@@ -162,6 +163,7 @@ static void *prism2_bss_list_proc_next(struct seq_file *m, void *v, loff_t *_pos ...@@ -162,6 +163,7 @@ static void *prism2_bss_list_proc_next(struct seq_file *m, void *v, loff_t *_pos
} }
static void prism2_bss_list_proc_stop(struct seq_file *m, void *v) static void prism2_bss_list_proc_stop(struct seq_file *m, void *v)
__releases(&local->lock)
{ {
local_info_t *local = PDE_DATA(file_inode(m->file)); local_info_t *local = PDE_DATA(file_inode(m->file));
spin_unlock_bh(&local->lock); spin_unlock_bh(&local->lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment