Commit 1d23a56b authored by Alex Elder's avatar Alex Elder Committed by Jakub Kicinski

net: ipa: set error code in gsi_channel_setup()

In gsi_channel_setup(), we check to see if the configuration data
contains any information about channels that are not supported by
the hardware.  If one is found, we abort the setup process, but
the error code (ret) is not set in this case.  Fix this bug.

Fixes: 650d1603 ("soc: qcom: ipa: the generic software interface")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarAlex Elder <elder@linaro.org>
Link: https://lore.kernel.org/r/20210204010655.15619-1-elder@linaro.orgSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 81b8be68
...@@ -1710,6 +1710,7 @@ static int gsi_channel_setup(struct gsi *gsi) ...@@ -1710,6 +1710,7 @@ static int gsi_channel_setup(struct gsi *gsi)
if (!channel->gsi) if (!channel->gsi)
continue; /* Ignore uninitialized channels */ continue; /* Ignore uninitialized channels */
ret = -EINVAL;
dev_err(gsi->dev, "channel %u not supported by hardware\n", dev_err(gsi->dev, "channel %u not supported by hardware\n",
channel_id - 1); channel_id - 1);
channel_id = gsi->channel_count; channel_id = gsi->channel_count;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment