Commit 1d605416 authored by Alexander Potapenko's avatar Alexander Potapenko Committed by Linus Torvalds

fs/binfmt_elf.c: allocate initialized memory in fill_thread_core_info()

KMSAN reported uninitialized data being written to disk when dumping
core.  As a result, several kilobytes of kmalloc memory may be written
to the core file and then read by a non-privileged user.
Reported-by: default avatarsam <sunhaoyl@outlook.com>
Signed-off-by: default avatarAlexander Potapenko <glider@google.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Acked-by: default avatarKees Cook <keescook@chromium.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: <stable@vger.kernel.org>
Link: http://lkml.kernel.org/r/20200419100848.63472-1-glider@google.com
Link: https://github.com/google/kmsan/issues/76Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 6988f31d
...@@ -1733,7 +1733,7 @@ static int fill_thread_core_info(struct elf_thread_core_info *t, ...@@ -1733,7 +1733,7 @@ static int fill_thread_core_info(struct elf_thread_core_info *t,
(!regset->active || regset->active(t->task, regset) > 0)) { (!regset->active || regset->active(t->task, regset) > 0)) {
int ret; int ret;
size_t size = regset_size(t->task, regset); size_t size = regset_size(t->task, regset);
void *data = kmalloc(size, GFP_KERNEL); void *data = kzalloc(size, GFP_KERNEL);
if (unlikely(!data)) if (unlikely(!data))
return 0; return 0;
ret = regset->get(t->task, regset, ret = regset->get(t->task, regset,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment