Commit 1d63d1d9 authored by Conor Dooley's avatar Conor Dooley Committed by Catalin Marinas

perf: starfive: fix 64-bit only COMPILE_TEST condition

ARCH_STARFIVE is not restricted to 64-bit platforms, so while Will's
addition of a 64-bit only condition satisfied the build robots doing
COMPILE_TEST builds, Palmer ran into the same problems with writeq()
being undefined during regular rv32 builds.

Promote the dependency on 64-bit to its own `depends on` so that the
driver can never be included in 32-bit builds.
Reported-by: default avatarPalmer Dabbelt <palmer@rivosinc.com>
Fixes: c2b24812 ("perf: starfive: Add StarLink PMU support")
Fixes: f0dbc6d0 ("perf: starfive: Only allow COMPILE_TEST for 64-bit architectures")
Signed-off-by: default avatarConor Dooley <conor.dooley@microchip.com>
Acked-by: default avatarWill Deacon <will@kernel.org>
Reviewed-by: default avatarPalmer Dabbelt <palmer@rivosinc.com>
Acked-by: default avatarPalmer Dabbelt <palmer@rivosinc.com>
Acked-by: default avatarJi Sheng Teoh <jisheng.teoh@starfivetech.com>
Acked-by: default avatarEmil Renner Berthing <emil.renner.berthing@canonical.com>
Link: https://lore.kernel.org/r/20240318-emphatic-rally-f177a4fe1bdc@spudSigned-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
parent 3fbd56f0
...@@ -87,7 +87,8 @@ config RISCV_PMU_SBI ...@@ -87,7 +87,8 @@ config RISCV_PMU_SBI
filtering, counter configuration. filtering, counter configuration.
config STARFIVE_STARLINK_PMU config STARFIVE_STARLINK_PMU
depends on ARCH_STARFIVE || (COMPILE_TEST && 64BIT) depends on ARCH_STARFIVE || COMPILE_TEST
depends on 64BIT
bool "StarFive StarLink PMU" bool "StarFive StarLink PMU"
help help
Provide support for StarLink Performance Monitor Unit. Provide support for StarLink Performance Monitor Unit.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment