Commit 1d9aa64c authored by Sylwester Nawrocki's avatar Sylwester Nawrocki

clk: samsung: Use common registration function for pll2550x

There is no such significant differences in pll2550x PLL type
to justify a separate registration function.  This patch adapts
exynos5440 driver to use the common function and removes
samsung_clk_register_pll2550x().
Signed-off-by: default avatarSylwester Nawrocki <s.nawrocki@samsung.com>
Reviewed-by: default avatarKrzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
parent 0299042d
...@@ -112,6 +112,11 @@ static struct notifier_block exynos5440_clk_restart_handler = { ...@@ -112,6 +112,11 @@ static struct notifier_block exynos5440_clk_restart_handler = {
.priority = 128, .priority = 128,
}; };
static const struct samsung_pll_clock exynos5440_plls[] __initconst = {
PLL(pll_2550x, CLK_CPLLA, "cplla", "xtal", 0, 0x4c, NULL),
PLL(pll_2550x, CLK_CPLLB, "cpllb", "xtal", 0, 0x50, NULL),
};
/* register exynos5440 clocks */ /* register exynos5440 clocks */
static void __init exynos5440_clk_init(struct device_node *np) static void __init exynos5440_clk_init(struct device_node *np)
{ {
...@@ -129,8 +134,8 @@ static void __init exynos5440_clk_init(struct device_node *np) ...@@ -129,8 +134,8 @@ static void __init exynos5440_clk_init(struct device_node *np)
samsung_clk_of_register_fixed_ext(ctx, exynos5440_fixed_rate_ext_clks, samsung_clk_of_register_fixed_ext(ctx, exynos5440_fixed_rate_ext_clks,
ARRAY_SIZE(exynos5440_fixed_rate_ext_clks), ext_clk_match); ARRAY_SIZE(exynos5440_fixed_rate_ext_clks), ext_clk_match);
samsung_clk_register_pll2550x("cplla", "xtal", reg_base + 0x1c, 0x10); samsung_clk_register_pll(ctx, exynos5440_plls,
samsung_clk_register_pll2550x("cpllb", "xtal", reg_base + 0x20, 0x10); ARRAY_SIZE(exynos5440_plls), ctx->reg_base);
samsung_clk_register_fixed_rate(ctx, exynos5440_fixed_rate_clks, samsung_clk_register_fixed_rate(ctx, exynos5440_fixed_rate_clks,
ARRAY_SIZE(exynos5440_fixed_rate_clks)); ARRAY_SIZE(exynos5440_fixed_rate_clks));
......
...@@ -890,22 +890,14 @@ static const struct clk_ops samsung_s3c2440_mpll_clk_ops = { ...@@ -890,22 +890,14 @@ static const struct clk_ops samsung_s3c2440_mpll_clk_ops = {
#define PLL2550X_M_SHIFT (4) #define PLL2550X_M_SHIFT (4)
#define PLL2550X_S_SHIFT (0) #define PLL2550X_S_SHIFT (0)
struct samsung_clk_pll2550x {
struct clk_hw hw;
const void __iomem *reg_base;
unsigned long offset;
};
#define to_clk_pll2550x(_hw) container_of(_hw, struct samsung_clk_pll2550x, hw)
static unsigned long samsung_pll2550x_recalc_rate(struct clk_hw *hw, static unsigned long samsung_pll2550x_recalc_rate(struct clk_hw *hw,
unsigned long parent_rate) unsigned long parent_rate)
{ {
struct samsung_clk_pll2550x *pll = to_clk_pll2550x(hw); struct samsung_clk_pll *pll = to_clk_pll(hw);
u32 r, p, m, s, pll_stat; u32 r, p, m, s, pll_stat;
u64 fvco = parent_rate; u64 fvco = parent_rate;
pll_stat = readl_relaxed(pll->reg_base + pll->offset * 3); pll_stat = readl_relaxed(pll->con_reg);
r = (pll_stat >> PLL2550X_R_SHIFT) & PLL2550X_R_MASK; r = (pll_stat >> PLL2550X_R_SHIFT) & PLL2550X_R_MASK;
if (!r) if (!r)
return 0; return 0;
...@@ -923,43 +915,6 @@ static const struct clk_ops samsung_pll2550x_clk_ops = { ...@@ -923,43 +915,6 @@ static const struct clk_ops samsung_pll2550x_clk_ops = {
.recalc_rate = samsung_pll2550x_recalc_rate, .recalc_rate = samsung_pll2550x_recalc_rate,
}; };
struct clk * __init samsung_clk_register_pll2550x(const char *name,
const char *pname, const void __iomem *reg_base,
const unsigned long offset)
{
struct samsung_clk_pll2550x *pll;
struct clk *clk;
struct clk_init_data init;
pll = kzalloc(sizeof(*pll), GFP_KERNEL);
if (!pll) {
pr_err("%s: could not allocate pll clk %s\n", __func__, name);
return NULL;
}
init.name = name;
init.ops = &samsung_pll2550x_clk_ops;
init.flags = CLK_GET_RATE_NOCACHE;
init.parent_names = &pname;
init.num_parents = 1;
pll->hw.init = &init;
pll->reg_base = reg_base;
pll->offset = offset;
clk = clk_register(NULL, &pll->hw);
if (IS_ERR(clk)) {
pr_err("%s: failed to register pll clock %s\n", __func__,
name);
kfree(pll);
}
if (clk_register_clkdev(clk, name, NULL))
pr_err("%s: failed to register lookup for %s", __func__, name);
return clk;
}
/* /*
* PLL2550xx Clock Type * PLL2550xx Clock Type
*/ */
...@@ -1263,6 +1218,9 @@ static void __init _samsung_clk_register_pll(struct samsung_clk_provider *ctx, ...@@ -1263,6 +1218,9 @@ static void __init _samsung_clk_register_pll(struct samsung_clk_provider *ctx,
else else
init.ops = &samsung_s3c2440_mpll_clk_ops; init.ops = &samsung_s3c2440_mpll_clk_ops;
break; break;
case pll_2550x:
init.ops = &samsung_pll2550x_clk_ops;
break;
case pll_2550xx: case pll_2550xx:
if (!pll->rate_table) if (!pll->rate_table)
init.ops = &samsung_pll2550xx_clk_min_ops; init.ops = &samsung_pll2550xx_clk_min_ops;
......
...@@ -31,6 +31,7 @@ enum samsung_pll_type { ...@@ -31,6 +31,7 @@ enum samsung_pll_type {
pll_s3c2410_mpll, pll_s3c2410_mpll,
pll_s3c2410_upll, pll_s3c2410_upll,
pll_s3c2440_mpll, pll_s3c2440_mpll,
pll_2550x,
pll_2550xx, pll_2550xx,
pll_2650xx, pll_2650xx,
pll_1450x, pll_1450x,
......
...@@ -14,6 +14,8 @@ ...@@ -14,6 +14,8 @@
#define CLK_XTAL 1 #define CLK_XTAL 1
#define CLK_ARM_CLK 2 #define CLK_ARM_CLK 2
#define CLK_CPLLA 3
#define CLK_CPLLB 4
#define CLK_SPI_BAUD 16 #define CLK_SPI_BAUD 16
#define CLK_PB0_250 17 #define CLK_PB0_250 17
#define CLK_PR0_250 18 #define CLK_PR0_250 18
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment