Commit 1efba35a authored by Christophe Leroy's avatar Christophe Leroy Committed by Linus Walleij

gpio: sysfs: avoid using kstrtol() in 'value' attribute write

A 'perf record' on an app continuously writing in the 'value'
attribute show that most of the time is spent in kstrtol()

--17.99%--value_store
          |
          |--10.17%--kstrtoint
          |          |
          |          |--8.82%--kstrtoll
          |
          |--2.50%--gpiod_set_value_cansleep
          |
          |--1.82%--u16_gpio_set
          |
          |--1.46%--value_store

The normal case is to write 0 or 1 in the attribute, therefore
this patch avoids the call to kstrtol() in the most common cases

Then 'perf record' shows

--7.21%--value_store
          |
          |--2.69%--u16_gpio_set
          |
          |--1.47%--value_store
          |
          |--1.08%--gpiod_set_value_cansleep
          |
          |--0.60%--mutex_lock
          |
           --0.58%--mutex_unlock
Signed-off-by: default avatarChristophe Leroy <christophe.leroy@c-s.fr>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 7a94b88c
...@@ -8,6 +8,7 @@ ...@@ -8,6 +8,7 @@
#include <linux/interrupt.h> #include <linux/interrupt.h>
#include <linux/kdev_t.h> #include <linux/kdev_t.h>
#include <linux/slab.h> #include <linux/slab.h>
#include <linux/ctype.h>
#include "gpiolib.h" #include "gpiolib.h"
...@@ -124,7 +125,7 @@ static ssize_t value_store(struct device *dev, ...@@ -124,7 +125,7 @@ static ssize_t value_store(struct device *dev,
{ {
struct gpiod_data *data = dev_get_drvdata(dev); struct gpiod_data *data = dev_get_drvdata(dev);
struct gpio_desc *desc = data->desc; struct gpio_desc *desc = data->desc;
ssize_t status; ssize_t status = 0;
mutex_lock(&data->mutex); mutex_lock(&data->mutex);
...@@ -133,7 +134,11 @@ static ssize_t value_store(struct device *dev, ...@@ -133,7 +134,11 @@ static ssize_t value_store(struct device *dev,
} else { } else {
long value; long value;
status = kstrtol(buf, 0, &value); if (size <= 2 && isdigit(buf[0]) &&
(size == 1 || buf[1] == '\n'))
value = buf[0] - '0';
else
status = kstrtol(buf, 0, &value);
if (status == 0) { if (status == 0) {
gpiod_set_value_cansleep(desc, value); gpiod_set_value_cansleep(desc, value);
status = size; status = size;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment