Commit 1ffc4b7c authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller

net: ll_temac: Fix an NULL vs IS_ERR() check in temac_open()

The phy_connect() function doesn't return NULL pointers.  It returns
error pointers on error, so I have updated the check.

Fixes: 8425c41d ("net: ll_temac: Extend support to non-device-tree platforms")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fdd1a810
...@@ -927,9 +927,9 @@ static int temac_open(struct net_device *ndev) ...@@ -927,9 +927,9 @@ static int temac_open(struct net_device *ndev)
} else if (strlen(lp->phy_name) > 0) { } else if (strlen(lp->phy_name) > 0) {
phydev = phy_connect(lp->ndev, lp->phy_name, temac_adjust_link, phydev = phy_connect(lp->ndev, lp->phy_name, temac_adjust_link,
lp->phy_interface); lp->phy_interface);
if (!phydev) { if (IS_ERR(phydev)) {
dev_err(lp->dev, "phy_connect() failed\n"); dev_err(lp->dev, "phy_connect() failed\n");
return -ENODEV; return PTR_ERR(phydev);
} }
phy_start(phydev); phy_start(phydev);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment