Commit 2013a4b6 authored by Zhen Lei's avatar Zhen Lei Committed by Arnd Bergmann

arm64: dts: broadcom: clear the warnings caused by empty dma-ranges

The scripts/dtc/checks.c requires that the node have empty "dma-ranges"
property must have the same "#address-cells" and "#size-cells" values as
the parent node. Otherwise, the following warnings is reported:

arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi:7.3-14: Warning \
(dma_ranges_format): /usb:dma-ranges: empty "dma-ranges" property but \
its #address-cells (1) differs from / (2)
arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi:7.3-14: Warning \
(dma_ranges_format): /usb:dma-ranges: empty "dma-ranges" property but \
its #size-cells (1) differs from / (2)

Arnd Bergmann figured out why it's necessary:
Also note that the #address-cells=<1> means that any device under
this bus is assumed to only support 32-bit addressing, and DMA will
have to go through a slow swiotlb in the absence of an IOMMU.
Suggested-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarZhen Lei <thunder.leizhen@huawei.com>
Link: https://lore.kernel.org/r/20201016090833.1892-2-thunder.leizhen@huawei.com'
Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
parent f8394f23
...@@ -5,20 +5,20 @@ ...@@ -5,20 +5,20 @@
usb { usb {
compatible = "simple-bus"; compatible = "simple-bus";
dma-ranges; dma-ranges;
#address-cells = <1>; #address-cells = <2>;
#size-cells = <1>; #size-cells = <2>;
ranges = <0x0 0x0 0x68500000 0x00400000>; ranges = <0x0 0x0 0x0 0x68500000 0x0 0x00400000>;
usbphy0: usb-phy@0 { usbphy0: usb-phy@0 {
compatible = "brcm,sr-usb-combo-phy"; compatible = "brcm,sr-usb-combo-phy";
reg = <0x00000000 0x100>; reg = <0x0 0x00000000 0x0 0x100>;
#phy-cells = <1>; #phy-cells = <1>;
status = "disabled"; status = "disabled";
}; };
xhci0: usb@1000 { xhci0: usb@1000 {
compatible = "generic-xhci"; compatible = "generic-xhci";
reg = <0x00001000 0x1000>; reg = <0x0 0x00001000 0x0 0x1000>;
interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>; interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>;
phys = <&usbphy0 1>, <&usbphy0 0>; phys = <&usbphy0 1>, <&usbphy0 0>;
phy-names = "phy0", "phy1"; phy-names = "phy0", "phy1";
...@@ -28,7 +28,7 @@ xhci0: usb@1000 { ...@@ -28,7 +28,7 @@ xhci0: usb@1000 {
bdc0: usb@2000 { bdc0: usb@2000 {
compatible = "brcm,bdc-v0.16"; compatible = "brcm,bdc-v0.16";
reg = <0x00002000 0x1000>; reg = <0x0 0x00002000 0x0 0x1000>;
interrupts = <GIC_SPI 259 IRQ_TYPE_LEVEL_HIGH>; interrupts = <GIC_SPI 259 IRQ_TYPE_LEVEL_HIGH>;
phys = <&usbphy0 0>, <&usbphy0 1>; phys = <&usbphy0 0>, <&usbphy0 1>;
phy-names = "phy0", "phy1"; phy-names = "phy0", "phy1";
...@@ -38,21 +38,21 @@ bdc0: usb@2000 { ...@@ -38,21 +38,21 @@ bdc0: usb@2000 {
usbphy1: usb-phy@10000 { usbphy1: usb-phy@10000 {
compatible = "brcm,sr-usb-combo-phy"; compatible = "brcm,sr-usb-combo-phy";
reg = <0x00010000 0x100>; reg = <0x0 0x00010000 0x0 0x100>;
#phy-cells = <1>; #phy-cells = <1>;
status = "disabled"; status = "disabled";
}; };
usbphy2: usb-phy@20000 { usbphy2: usb-phy@20000 {
compatible = "brcm,sr-usb-hs-phy"; compatible = "brcm,sr-usb-hs-phy";
reg = <0x00020000 0x100>; reg = <0x0 0x00020000 0x0 0x100>;
#phy-cells = <0>; #phy-cells = <0>;
status = "disabled"; status = "disabled";
}; };
xhci1: usb@11000 { xhci1: usb@11000 {
compatible = "generic-xhci"; compatible = "generic-xhci";
reg = <0x00011000 0x1000>; reg = <0x0 0x00011000 0x0 0x1000>;
interrupts = <GIC_SPI 263 IRQ_TYPE_LEVEL_HIGH>; interrupts = <GIC_SPI 263 IRQ_TYPE_LEVEL_HIGH>;
phys = <&usbphy1 1>, <&usbphy2>, <&usbphy1 0>; phys = <&usbphy1 1>, <&usbphy2>, <&usbphy1 0>;
phy-names = "phy0", "phy1", "phy2"; phy-names = "phy0", "phy1", "phy2";
...@@ -62,7 +62,7 @@ xhci1: usb@11000 { ...@@ -62,7 +62,7 @@ xhci1: usb@11000 {
bdc1: usb@21000 { bdc1: usb@21000 {
compatible = "brcm,bdc-v0.16"; compatible = "brcm,bdc-v0.16";
reg = <0x00021000 0x1000>; reg = <0x0 0x00021000 0x0 0x1000>;
interrupts = <GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>; interrupts = <GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>;
phys = <&usbphy2>; phys = <&usbphy2>;
phy-names = "phy0"; phy-names = "phy0";
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment