Commit 208b5899 authored by Sudeep Holla's avatar Sudeep Holla

soc: ux500: Switch to use DEVICE_ATTR_RO()

Move device attributes to DEVICE_ATTR_RO() as that would make things
a lot more "obvious" what is happening over the existing __ATTR usage.

Link: https://lore.kernel.org/r/20200523170859.50003-6-sudeep.holla@arm.com
Cc: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarSudeep Holla <sudeep.holla@arm.com>
parent be0db32f
...@@ -146,9 +146,8 @@ static const char * __init ux500_get_revision(void) ...@@ -146,9 +146,8 @@ static const char * __init ux500_get_revision(void)
return kasprintf(GFP_KERNEL, "%s", "Unknown"); return kasprintf(GFP_KERNEL, "%s", "Unknown");
} }
static ssize_t ux500_get_process(struct device *dev, static ssize_t
struct device_attribute *attr, process_show(struct device *dev, struct device_attribute *attr, char *buf)
char *buf)
{ {
if (dbx500_id.process == 0x00) if (dbx500_id.process == 0x00)
return sprintf(buf, "Standard\n"); return sprintf(buf, "Standard\n");
...@@ -156,6 +155,8 @@ static ssize_t ux500_get_process(struct device *dev, ...@@ -156,6 +155,8 @@ static ssize_t ux500_get_process(struct device *dev,
return sprintf(buf, "%02xnm\n", dbx500_id.process); return sprintf(buf, "%02xnm\n", dbx500_id.process);
} }
static DEVICE_ATTR_RO(process);
static const char *db8500_read_soc_id(struct device_node *backupram) static const char *db8500_read_soc_id(struct device_node *backupram)
{ {
void __iomem *base; void __iomem *base;
...@@ -186,9 +187,6 @@ static void __init soc_info_populate(struct soc_device_attribute *soc_dev_attr, ...@@ -186,9 +187,6 @@ static void __init soc_info_populate(struct soc_device_attribute *soc_dev_attr,
soc_dev_attr->revision = ux500_get_revision(); soc_dev_attr->revision = ux500_get_revision();
} }
static const struct device_attribute ux500_soc_attr =
__ATTR(process, S_IRUGO, ux500_get_process, NULL);
static int __init ux500_soc_device_init(void) static int __init ux500_soc_device_init(void)
{ {
struct device *parent; struct device *parent;
...@@ -218,7 +216,7 @@ static int __init ux500_soc_device_init(void) ...@@ -218,7 +216,7 @@ static int __init ux500_soc_device_init(void)
} }
parent = soc_device_to_device(soc_dev); parent = soc_device_to_device(soc_dev);
device_create_file(parent, &ux500_soc_attr); device_create_file(parent, &dev_attr_process);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment