Commit 20f2e67c authored by Denis Pauk's avatar Denis Pauk Committed by Guenter Roeck

hwmon: (nct6775) Additional check for ChipID before ASUS WMI usage

WMI monitoring methods can be changed or removed in new ASUS boards
BIOS versions. Such versions return zero instead of a real one as
Chip ID.

Commit adds additional validation for the result of Chip ID call
before enabling access by ASUS WMI methods.

BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=204807Signed-off-by: default avatarDenis Pauk <pauk.denis@gmail.com>
Link: https://lore.kernel.org/r/20211218205206.615865-1-pauk.denis@gmail.comSigned-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent a8d6d499
...@@ -5038,7 +5038,7 @@ static int __init sensors_nct6775_init(void) ...@@ -5038,7 +5038,7 @@ static int __init sensors_nct6775_init(void)
board_name); board_name);
if (err >= 0) { if (err >= 0) {
/* if reading chip id via WMI succeeds, use WMI */ /* if reading chip id via WMI succeeds, use WMI */
if (!nct6775_asuswmi_read(0, NCT6775_PORT_CHIPID, &tmp)) { if (!nct6775_asuswmi_read(0, NCT6775_PORT_CHIPID, &tmp) && tmp) {
pr_info("Using Asus WMI to access %#x chip.\n", tmp); pr_info("Using Asus WMI to access %#x chip.\n", tmp);
access = access_asuswmi; access = access_asuswmi;
} else { } else {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment