Commit 20fcefe5 authored by Milton Miller's avatar Milton Miller Committed by Benjamin Herrenschmidt

powerpc/numa: Avoid possible reference beyond prop. length in find_min_common_depth()

find_min_common_depth() was checking the property length incorrectly.
The value is in bytes not cells, and it is using the second entry.
Signed-off-By: default avatarMilton Miller <miltonm@bga.com>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent 6a4d7a90
...@@ -289,7 +289,7 @@ static int __init find_min_common_depth(void) ...@@ -289,7 +289,7 @@ static int __init find_min_common_depth(void)
ref_points = of_get_property(rtas_root, ref_points = of_get_property(rtas_root,
"ibm,associativity-reference-points", &len); "ibm,associativity-reference-points", &len);
if ((len >= 1) && ref_points) { if ((len >= 2 * sizeof(unsigned int)) && ref_points) {
depth = ref_points[1]; depth = ref_points[1];
} else { } else {
dbg("NUMA: ibm,associativity-reference-points not found.\n"); dbg("NUMA: ibm,associativity-reference-points not found.\n");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment