Commit 216f5053 authored by Oliver Neukum's avatar Oliver Neukum Committed by Ben Hutchings

usbnet: cleanup after bind() in probe()

commit 1666984c upstream.

In case bind() works, but a later error forces bailing
in probe() in error cases work and a timer may be scheduled.
They must be killed. This fixes an error case related to
the double free reported in
http://www.spinics.net/lists/netdev/msg367669.html
and needs to go on top of Linus' fix to cdc-ncm.
Signed-off-by: default avatarOliver Neukum <ONeukum@suse.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
parent 89df0e7a
...@@ -1729,6 +1729,13 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod) ...@@ -1729,6 +1729,13 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
if (info->unbind) if (info->unbind)
info->unbind (dev, udev); info->unbind (dev, udev);
out1: out1:
/* subdrivers must undo all they did in bind() if they
* fail it, but we may fail later and a deferred kevent
* may trigger an error resubmitting itself and, worse,
* schedule a timer. So we kill it all just in case.
*/
cancel_work_sync(&dev->kevent);
del_timer_sync(&dev->delay);
free_netdev(net); free_netdev(net);
out: out:
return status; return status;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment