Commit 21733cb5 authored by Eric Lin's avatar Eric Lin Committed by Palmer Dabbelt

riscv/mm: Introduce a die_kernel_fault() helper function

Like arm64, this patch adds a die_kernel_fault() helper
to ensure the same semantics for the different kernel faults.
Signed-off-by: default avatarEric Lin <tesheng@andestech.com>
Reviewed-by: default avatarPekka Enberg <penberg@kernel.org>
Signed-off-by: default avatarPalmer Dabbelt <palmerdabbelt@google.com>
parent 641e8cd2
...@@ -19,8 +19,23 @@ ...@@ -19,8 +19,23 @@
#include "../kernel/head.h" #include "../kernel/head.h"
static void die_kernel_fault(const char *msg, unsigned long addr,
struct pt_regs *regs)
{
bust_spinlocks(1);
pr_alert("Unable to handle kernel %s at virtual address " REG_FMT "\n", msg,
addr);
bust_spinlocks(0);
die(regs, "Oops");
do_exit(SIGKILL);
}
static inline void no_context(struct pt_regs *regs, unsigned long addr) static inline void no_context(struct pt_regs *regs, unsigned long addr)
{ {
const char *msg;
/* Are we prepared to handle this kernel fault? */ /* Are we prepared to handle this kernel fault? */
if (fixup_exception(regs)) if (fixup_exception(regs))
return; return;
...@@ -29,12 +44,8 @@ static inline void no_context(struct pt_regs *regs, unsigned long addr) ...@@ -29,12 +44,8 @@ static inline void no_context(struct pt_regs *regs, unsigned long addr)
* Oops. The kernel tried to access some bad page. We'll have to * Oops. The kernel tried to access some bad page. We'll have to
* terminate things with extreme prejudice. * terminate things with extreme prejudice.
*/ */
bust_spinlocks(1); msg = (addr < PAGE_SIZE) ? "NULL pointer dereference" : "paging request";
pr_alert("Unable to handle kernel %s at virtual address " REG_FMT "\n", die_kernel_fault(msg, addr, regs);
(addr < PAGE_SIZE) ? "NULL pointer dereference" :
"paging request", addr);
die(regs, "Oops");
do_exit(SIGKILL);
} }
static inline void mm_fault_error(struct pt_regs *regs, unsigned long addr, vm_fault_t fault) static inline void mm_fault_error(struct pt_regs *regs, unsigned long addr, vm_fault_t fault)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment