Commit 21a71a48 authored by Andrew Morton's avatar Andrew Morton Committed by Linus Torvalds

[PATCH] fix wakeup_secondary_cpu warning, code bloat

Only one of wakeup_secondary_via_NMI() and wakeup_secondary_via_INIT() is
needed.  We're currently compiling both, which generates an unused function
warning.
parent 5b5dfafb
...@@ -596,12 +596,14 @@ static inline void inquire_remote_apic(int apicid) ...@@ -596,12 +596,14 @@ static inline void inquire_remote_apic(int apicid)
} }
#endif #endif
static int __init wakeup_secondary_via_NMI(int logical_apicid) #ifdef WAKE_SECONDARY_VIA_NMI
/* /*
* Poke the other CPU in the eye to wake it up. Remember that the normal * Poke the other CPU in the eye via NMI to wake it up. Remember that the normal
* INIT, INIT, STARTUP sequence will reset the chip hard for us, and this * INIT, INIT, STARTUP sequence will reset the chip hard for us, and this
* won't ... remember to clear down the APIC, etc later. * won't ... remember to clear down the APIC, etc later.
*/ */
static int __init
wakeup_secondary_cpu(int logical_apicid, unsigned long start_eip)
{ {
unsigned long send_status = 0, accept_status = 0; unsigned long send_status = 0, accept_status = 0;
int timeout, maxlvt; int timeout, maxlvt;
...@@ -643,8 +645,11 @@ static int __init wakeup_secondary_via_NMI(int logical_apicid) ...@@ -643,8 +645,11 @@ static int __init wakeup_secondary_via_NMI(int logical_apicid)
return (send_status | accept_status); return (send_status | accept_status);
} }
#endif /* WAKE_SECONDARY_VIA_NMI */
static int __init wakeup_secondary_via_INIT(int phys_apicid, unsigned long start_eip) #ifdef WAKE_SECONDARY_VIA_INIT
static int __init
wakeup_secondary_cpu(int phys_apicid, unsigned long start_eip)
{ {
unsigned long send_status = 0, accept_status = 0; unsigned long send_status = 0, accept_status = 0;
int maxlvt, timeout, num_starts, j; int maxlvt, timeout, num_starts, j;
...@@ -766,6 +771,7 @@ static int __init wakeup_secondary_via_INIT(int phys_apicid, unsigned long start ...@@ -766,6 +771,7 @@ static int __init wakeup_secondary_via_INIT(int phys_apicid, unsigned long start
return (send_status | accept_status); return (send_status | accept_status);
} }
#endif /* WAKE_SECONDARY_VIA_INIT */
extern unsigned long cpu_initialized; extern unsigned long cpu_initialized;
......
...@@ -73,8 +73,7 @@ static inline int mpc_apic_id(struct mpc_config_processor *m, int quad) ...@@ -73,8 +73,7 @@ static inline int mpc_apic_id(struct mpc_config_processor *m, int quad)
return (m->mpc_apicid); return (m->mpc_apicid);
} }
#define wakeup_secondary_cpu(apicid, start_eip) \ #define WAKE_SECONDARY_VIA_INIT
wakeup_secondary_via_INIT(apicid, start_eip)
static inline void setup_portio_remap(void) static inline void setup_portio_remap(void)
{ {
......
...@@ -69,8 +69,7 @@ static inline int mpc_apic_id(struct mpc_config_processor *m, int quad) ...@@ -69,8 +69,7 @@ static inline int mpc_apic_id(struct mpc_config_processor *m, int quad)
return logical_apicid; return logical_apicid;
} }
#define wakeup_secondary_cpu(apicid, start_eip) \ #define WAKE_SECONDARY_VIA_NMI
wakeup_secondary_via_NMI(apicid)
static inline void setup_portio_remap(void) static inline void setup_portio_remap(void)
{ {
......
...@@ -54,8 +54,7 @@ static inline unsigned long apicid_to_phys_cpu_present(int apicid) ...@@ -54,8 +54,7 @@ static inline unsigned long apicid_to_phys_cpu_present(int apicid)
return (1ul << apicid); return (1ul << apicid);
} }
#define wakeup_secondary_cpu(apicid, start_eip) \ #define WAKE_SECONDARY_VIA_INIT
wakeup_secondary_via_INIT(apicid, start_eip)
static inline void setup_portio_remap(void) static inline void setup_portio_remap(void)
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment