Commit 21f374c6 authored by Joe Perches's avatar Joe Perches Committed by David S. Miller

bonding: Invert test

Make the error case return early.
Make the normal return at the bottom of the function.
Reduces indent for readability.
Signed-off-by: default avatarJoe Perches <joe@perches.com>
Reviewed-by: default avatarDing Tianhong <dingtianhong@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 157550fb
...@@ -2379,17 +2379,16 @@ int __bond_3ad_get_active_agg_info(struct bonding *bond, ...@@ -2379,17 +2379,16 @@ int __bond_3ad_get_active_agg_info(struct bonding *bond,
} }
} }
if (aggregator) { if (!aggregator)
ad_info->aggregator_id = aggregator->aggregator_identifier; return -1;
ad_info->ports = aggregator->num_of_ports;
ad_info->actor_key = aggregator->actor_oper_aggregator_key; ad_info->aggregator_id = aggregator->aggregator_identifier;
ad_info->partner_key = aggregator->partner_oper_aggregator_key; ad_info->ports = aggregator->num_of_ports;
ether_addr_copy(ad_info->partner_system, ad_info->actor_key = aggregator->actor_oper_aggregator_key;
aggregator->partner_system.mac_addr_value); ad_info->partner_key = aggregator->partner_oper_aggregator_key;
return 0; ether_addr_copy(ad_info->partner_system,
} aggregator->partner_system.mac_addr_value);
return 0;
return -1;
} }
/* Wrapper used to hold bond->lock so no slave manipulation can occur */ /* Wrapper used to hold bond->lock so no slave manipulation can occur */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment