Commit 2203bd0e authored by Dan Carpenter's avatar Dan Carpenter Committed by Rob Clark

drm/msm: uninitialized variable in msm_gem_import()

The msm_gem_new_impl() function cleans up after itself so there is no
need to call drm_gem_object_put().  Conceptually, it does not make sense
to call a kref_put() function until after the reference counting has
been initialized which happens immediately after this call in the
drm_gem_(private_)object_init() functions.

In the msm_gem_import() function the "obj" pointer is uninitialized, so
it will lead to a crash.

Fixes: 05b84911 ("drm/msm: prime support")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20211013081315.GG6010@kiliSigned-off-by: default avatarRob Clark <robdclark@chromium.org>
parent 027d052a
...@@ -1167,7 +1167,7 @@ struct drm_gem_object *msm_gem_new(struct drm_device *dev, uint32_t size, uint32 ...@@ -1167,7 +1167,7 @@ struct drm_gem_object *msm_gem_new(struct drm_device *dev, uint32_t size, uint32
ret = msm_gem_new_impl(dev, size, flags, &obj); ret = msm_gem_new_impl(dev, size, flags, &obj);
if (ret) if (ret)
goto fail; return ERR_PTR(ret);
msm_obj = to_msm_bo(obj); msm_obj = to_msm_bo(obj);
...@@ -1251,7 +1251,7 @@ struct drm_gem_object *msm_gem_import(struct drm_device *dev, ...@@ -1251,7 +1251,7 @@ struct drm_gem_object *msm_gem_import(struct drm_device *dev,
ret = msm_gem_new_impl(dev, size, MSM_BO_WC, &obj); ret = msm_gem_new_impl(dev, size, MSM_BO_WC, &obj);
if (ret) if (ret)
goto fail; return ERR_PTR(ret);
drm_gem_private_object_init(dev, obj, size); drm_gem_private_object_init(dev, obj, size);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment