Commit 223125e3 authored by Qinglang Miao's avatar Qinglang Miao Committed by Wolfram Sang

i2c: img-scb: fix reference leak when pm_runtime_get_sync fails

The PM reference count is not expected to be incremented on
return in functions img_i2c_xfer and img_i2c_init.

However, pm_runtime_get_sync will increment the PM reference
count even failed. Forgetting to putting operation will result
in a reference leak here.

Replace it with pm_runtime_resume_and_get to keep usage
counter balanced.

Fixes: 93222bd9 ("i2c: img-scb: Add runtime PM")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarQinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent 23ceb846
...@@ -1057,7 +1057,7 @@ static int img_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, ...@@ -1057,7 +1057,7 @@ static int img_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,
atomic = true; atomic = true;
} }
ret = pm_runtime_get_sync(adap->dev.parent); ret = pm_runtime_resume_and_get(adap->dev.parent);
if (ret < 0) if (ret < 0)
return ret; return ret;
...@@ -1158,7 +1158,7 @@ static int img_i2c_init(struct img_i2c *i2c) ...@@ -1158,7 +1158,7 @@ static int img_i2c_init(struct img_i2c *i2c)
u32 rev; u32 rev;
int ret; int ret;
ret = pm_runtime_get_sync(i2c->adap.dev.parent); ret = pm_runtime_resume_and_get(i2c->adap.dev.parent);
if (ret < 0) if (ret < 0)
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment