Commit 2287c636 authored by Yazen Ghannam's avatar Yazen Ghannam Committed by Borislav Petkov

EDAC, amd64: Save and return err code from probe_one_instance()

We should save the return code from probe_one_instance() so that it can
be returned from the module init function. Otherwise, we'll be returning
the -ENOMEM from above.
Signed-off-by: default avatarYazen Ghannam <Yazen.Ghannam@amd.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/1484322741-41884-1-git-send-email-Yazen.Ghannam@amd.comSigned-off-by: default avatarBorislav Petkov <bp@suse.de>
parent f5c61277
...@@ -3466,14 +3466,16 @@ static int __init amd64_edac_init(void) ...@@ -3466,14 +3466,16 @@ static int __init amd64_edac_init(void)
if (!msrs) if (!msrs)
goto err_free; goto err_free;
for (i = 0; i < amd_nb_num(); i++) for (i = 0; i < amd_nb_num(); i++) {
if (probe_one_instance(i)) { err = probe_one_instance(i);
if (err) {
/* unwind properly */ /* unwind properly */
while (--i >= 0) while (--i >= 0)
remove_one_instance(i); remove_one_instance(i);
goto err_pci; goto err_pci;
} }
}
setup_pci_device(); setup_pci_device();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment