Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
L
linux
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
linux
Commits
22add2b2
Commit
22add2b2
authored
Mar 06, 2003
by
Alan Cox
Committed by
Linus Torvalds
Mar 06, 2003
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[PATCH] switch ide-io (core ioctls etc) to ide_execute_command
Also fix the irq masking bug
parent
1b34a8bb
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
7 additions
and
10 deletions
+7
-10
drivers/ide/ide-io.c
drivers/ide/ide-io.c
+7
-10
No files found.
drivers/ide/ide-io.c
View file @
22add2b2
...
@@ -358,18 +358,15 @@ EXPORT_SYMBOL(ide_error);
...
@@ -358,18 +358,15 @@ EXPORT_SYMBOL(ide_error);
* Issue a simple drive command with interrupts.
* Issue a simple drive command with interrupts.
* The drive must be selected beforehand.
* The drive must be selected beforehand.
*/
*/
void
ide_cmd
(
ide_drive_t
*
drive
,
u8
cmd
,
u8
nsect
,
ide_handler_t
*
handler
)
void
ide_cmd
(
ide_drive_t
*
drive
,
u8
cmd
,
u8
nsect
,
ide_handler_t
*
handler
)
{
{
ide_hwif_t
*
hwif
=
HWIF
(
drive
);
ide_hwif_t
*
hwif
=
HWIF
(
drive
);
if
(
HWGROUP
(
drive
)
->
handler
!=
NULL
)
BUG
();
ide_set_handler
(
drive
,
handler
,
WAIT_CMD
,
NULL
);
if
(
IDE_CONTROL_REG
)
if
(
IDE_CONTROL_REG
)
hwif
->
OUTB
(
drive
->
ctl
,
IDE_CONTROL_REG
);
/* clear nIEN */
hwif
->
OUTB
(
drive
->
ctl
,
IDE_CONTROL_REG
);
/* clear nIEN */
SELECT_MASK
(
drive
,
0
);
SELECT_MASK
(
drive
,
0
);
hwif
->
OUTB
(
nsect
,
IDE_NSECTOR_REG
);
hwif
->
OUTB
(
nsect
,
IDE_NSECTOR_REG
);
hwif
->
OUTB
(
cmd
,
IDE_COMMAND_REG
);
ide_execute_command
(
drive
,
cmd
,
handler
,
WAIT_CMD
,
NULL
);
}
}
EXPORT_SYMBOL
(
ide_cmd
);
EXPORT_SYMBOL
(
ide_cmd
);
...
@@ -841,14 +838,14 @@ void ide_do_request (ide_hwgroup_t *hwgroup, int masked_irq)
...
@@ -841,14 +838,14 @@ void ide_do_request (ide_hwgroup_t *hwgroup, int masked_irq)
* happens anyway when any interrupt comes in, IDE or otherwise
* happens anyway when any interrupt comes in, IDE or otherwise
* -- the kernel masks the IRQ while it is being handled.
* -- the kernel masks the IRQ while it is being handled.
*/
*/
if
(
masked_irq
&&
hwif
->
irq
!=
masked_irq
)
if
(
hwif
->
irq
!=
masked_irq
)
disable_irq_nosync
(
hwif
->
irq
);
disable_irq_nosync
(
hwif
->
irq
);
spin_unlock
(
&
ide_lock
);
spin_unlock
(
&
ide_lock
);
local_irq_enable
();
local_irq_enable
();
/* allow other IRQs while we start this request */
/* allow other IRQs while we start this request */
startstop
=
start_request
(
drive
,
rq
);
startstop
=
start_request
(
drive
,
rq
);
spin_lock_irq
(
&
ide_lock
);
spin_lock_irq
(
&
ide_lock
);
if
(
masked_irq
&&
hwif
->
irq
!=
masked_irq
)
if
(
hwif
->
irq
!=
masked_irq
)
enable_irq
(
hwif
->
irq
);
enable_irq
(
hwif
->
irq
);
if
(
startstop
==
ide_released
)
if
(
startstop
==
ide_released
)
goto
queue_next
;
goto
queue_next
;
...
@@ -864,7 +861,7 @@ EXPORT_SYMBOL(ide_do_request);
...
@@ -864,7 +861,7 @@ EXPORT_SYMBOL(ide_do_request);
*/
*/
void
do_ide_request
(
request_queue_t
*
q
)
void
do_ide_request
(
request_queue_t
*
q
)
{
{
ide_do_request
(
q
->
queuedata
,
0
);
ide_do_request
(
q
->
queuedata
,
IDE_NO_IRQ
);
}
}
/*
/*
...
@@ -1012,7 +1009,7 @@ void ide_timer_expiry (unsigned long data)
...
@@ -1012,7 +1009,7 @@ void ide_timer_expiry (unsigned long data)
hwgroup
->
busy
=
0
;
hwgroup
->
busy
=
0
;
}
}
}
}
ide_do_request
(
hwgroup
,
0
);
ide_do_request
(
hwgroup
,
IDE_NO_IRQ
);
spin_unlock_irqrestore
(
&
ide_lock
,
flags
);
spin_unlock_irqrestore
(
&
ide_lock
,
flags
);
}
}
...
@@ -1302,7 +1299,7 @@ int ide_do_drive_cmd (ide_drive_t *drive, struct request *rq, ide_action_t actio
...
@@ -1302,7 +1299,7 @@ int ide_do_drive_cmd (ide_drive_t *drive, struct request *rq, ide_action_t actio
insert_end
=
0
;
insert_end
=
0
;
}
}
__elv_add_request
(
&
drive
->
queue
,
rq
,
insert_end
,
0
);
__elv_add_request
(
&
drive
->
queue
,
rq
,
insert_end
,
0
);
ide_do_request
(
hwgroup
,
0
);
ide_do_request
(
hwgroup
,
IDE_NO_IRQ
);
spin_unlock_irqrestore
(
&
ide_lock
,
flags
);
spin_unlock_irqrestore
(
&
ide_lock
,
flags
);
err
=
0
;
err
=
0
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment