Commit 23492754 authored by Michael S. Tsirkin's avatar Michael S. Tsirkin

xen/events: use virt_xxx barriers

drivers/xen/events/events_fifo.c uses rmb() to communicate with the
other side.

For guests compiled with CONFIG_SMP, smp_rmb would be sufficient, so
rmb() here is only needed if a non-SMP guest runs on an SMP host.

Switch to the virt_rmb barrier which serves this exact purpose.

Pull in asm/barrier.h here to make sure the file is self-contained.
Suggested-by: default avatarDavid Vrabel <david.vrabel@citrix.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Acked-by: default avatarDavid Vrabel <david.vrabel@citrix.com>
Acked-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
parent 506b02eb
...@@ -41,6 +41,7 @@ ...@@ -41,6 +41,7 @@
#include <linux/percpu.h> #include <linux/percpu.h>
#include <linux/cpu.h> #include <linux/cpu.h>
#include <asm/barrier.h>
#include <asm/sync_bitops.h> #include <asm/sync_bitops.h>
#include <asm/xen/hypercall.h> #include <asm/xen/hypercall.h>
#include <asm/xen/hypervisor.h> #include <asm/xen/hypervisor.h>
...@@ -296,7 +297,7 @@ static void consume_one_event(unsigned cpu, ...@@ -296,7 +297,7 @@ static void consume_one_event(unsigned cpu,
* control block. * control block.
*/ */
if (head == 0) { if (head == 0) {
rmb(); /* Ensure word is up-to-date before reading head. */ virt_rmb(); /* Ensure word is up-to-date before reading head. */
head = control_block->head[priority]; head = control_block->head[priority];
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment