Commit 23b37e1e authored by Vasiliy Kulikov's avatar Vasiliy Kulikov Committed by Greg Kroah-Hartman

mfd: ab3100: world-writable debugfs *_priv files

commit f8a06977 upstream.

Don't allow everybody to change device hardware registers.
Signed-off-by: default avatarVasiliy Kulikov <segoon@openwall.com>
Acked-by: default avatarLinus Walleij <linus.walleij@stericsson.com>
Signed-off-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent a41e7f1d
...@@ -591,7 +591,7 @@ static void ab3100_setup_debugfs(struct ab3100 *ab3100) ...@@ -591,7 +591,7 @@ static void ab3100_setup_debugfs(struct ab3100 *ab3100)
ab3100_get_priv.ab3100 = ab3100; ab3100_get_priv.ab3100 = ab3100;
ab3100_get_priv.mode = false; ab3100_get_priv.mode = false;
ab3100_get_reg_file = debugfs_create_file("get_reg", ab3100_get_reg_file = debugfs_create_file("get_reg",
S_IWUGO, ab3100_dir, &ab3100_get_priv, S_IWUSR, ab3100_dir, &ab3100_get_priv,
&ab3100_get_set_reg_fops); &ab3100_get_set_reg_fops);
if (!ab3100_get_reg_file) { if (!ab3100_get_reg_file) {
err = -ENOMEM; err = -ENOMEM;
...@@ -601,7 +601,7 @@ static void ab3100_setup_debugfs(struct ab3100 *ab3100) ...@@ -601,7 +601,7 @@ static void ab3100_setup_debugfs(struct ab3100 *ab3100)
ab3100_set_priv.ab3100 = ab3100; ab3100_set_priv.ab3100 = ab3100;
ab3100_set_priv.mode = true; ab3100_set_priv.mode = true;
ab3100_set_reg_file = debugfs_create_file("set_reg", ab3100_set_reg_file = debugfs_create_file("set_reg",
S_IWUGO, ab3100_dir, &ab3100_set_priv, S_IWUSR, ab3100_dir, &ab3100_set_priv,
&ab3100_get_set_reg_fops); &ab3100_get_set_reg_fops);
if (!ab3100_set_reg_file) { if (!ab3100_set_reg_file) {
err = -ENOMEM; err = -ENOMEM;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment