Commit 23de1973 authored by Hans Holmberg's avatar Hans Holmberg Committed by Luis Henriques

gpiolib: of: Correct error handling in of_get_named_gpiod_flags

commit 7b8792bb upstream.

of_get_named_gpiod_flags fails with -EPROBE_DEFER in cases
where the gpio chip is available and the GPIO translation fails.

This causes drivers to be re-probed erroneusly, and hides the
real problem(i.e. the GPIO number being out of range).
Signed-off-by: default avatarHans Holmberg <hans.holmberg@intel.com>
Reviewed-by: default avatarAlexandre Courbot <acourbot@nvidia.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent 9cd053c7
...@@ -45,8 +45,14 @@ static int of_gpiochip_find_and_xlate(struct gpio_chip *gc, void *data) ...@@ -45,8 +45,14 @@ static int of_gpiochip_find_and_xlate(struct gpio_chip *gc, void *data)
return false; return false;
ret = gc->of_xlate(gc, &gg_data->gpiospec, gg_data->flags); ret = gc->of_xlate(gc, &gg_data->gpiospec, gg_data->flags);
if (ret < 0) if (ret < 0) {
return false; /* We've found the gpio chip, but the translation failed.
* Return true to stop looking and return the translation
* error via out_gpio
*/
gg_data->out_gpio = ERR_PTR(ret);
return true;
}
gg_data->out_gpio = gpiochip_get_desc(gc, ret); gg_data->out_gpio = gpiochip_get_desc(gc, ret);
return true; return true;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment