Commit 2403d6f1 authored by Chen-Yu Tsai's avatar Chen-Yu Tsai Committed by Stephen Boyd

clk: mediatek: Use %pe to print errors

If %pe is used to print errors, a string representation of the error
would be printed instead of a number as with %ld. Also, all the sites
printing errors are deriving the error code from a pointer. Using %pe
is more straightforward.
Signed-off-by: default avatarChen-Yu Tsai <wenst@chromium.org>
Reviewed-by: default avatarMiles Chen <miles.chen@mediatek.com>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20220208124034.414635-2-wenst@chromium.orgReviewed-by: default avatarChun-Jie Chen <chun-jie.chen@mediatek.com>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent 7a688c91
...@@ -92,7 +92,7 @@ struct clk * __init mtk_clk_register_ref2usb_tx(const char *name, ...@@ -92,7 +92,7 @@ struct clk * __init mtk_clk_register_ref2usb_tx(const char *name,
clk = clk_register(NULL, &tx->hw); clk = clk_register(NULL, &tx->hw);
if (IS_ERR(clk)) { if (IS_ERR(clk)) {
pr_err("Failed to register clk %s: %ld\n", name, PTR_ERR(clk)); pr_err("Failed to register clk %s: %pe\n", name, clk);
kfree(tx); kfree(tx);
} }
......
...@@ -87,8 +87,7 @@ int mtk_clk_register_cpumuxes(struct device_node *node, ...@@ -87,8 +87,7 @@ int mtk_clk_register_cpumuxes(struct device_node *node,
regmap = device_node_to_regmap(node); regmap = device_node_to_regmap(node);
if (IS_ERR(regmap)) { if (IS_ERR(regmap)) {
pr_err("Cannot find regmap for %pOF: %ld\n", node, pr_err("Cannot find regmap for %pOF: %pe\n", node, regmap);
PTR_ERR(regmap));
return PTR_ERR(regmap); return PTR_ERR(regmap);
} }
...@@ -97,8 +96,7 @@ int mtk_clk_register_cpumuxes(struct device_node *node, ...@@ -97,8 +96,7 @@ int mtk_clk_register_cpumuxes(struct device_node *node,
clk = mtk_clk_register_cpumux(mux, regmap); clk = mtk_clk_register_cpumux(mux, regmap);
if (IS_ERR(clk)) { if (IS_ERR(clk)) {
pr_err("Failed to register clk %s: %ld\n", pr_err("Failed to register clk %s: %pe\n", mux->name, clk);
mux->name, PTR_ERR(clk));
continue; continue;
} }
......
...@@ -70,8 +70,7 @@ void mtk_clk_register_fixed_clks(const struct mtk_fixed_clk *clks, ...@@ -70,8 +70,7 @@ void mtk_clk_register_fixed_clks(const struct mtk_fixed_clk *clks,
rc->rate); rc->rate);
if (IS_ERR(clk)) { if (IS_ERR(clk)) {
pr_err("Failed to register clk %s: %ld\n", pr_err("Failed to register clk %s: %pe\n", rc->name, clk);
rc->name, PTR_ERR(clk));
continue; continue;
} }
...@@ -97,8 +96,7 @@ void mtk_clk_register_factors(const struct mtk_fixed_factor *clks, ...@@ -97,8 +96,7 @@ void mtk_clk_register_factors(const struct mtk_fixed_factor *clks,
CLK_SET_RATE_PARENT, ff->mult, ff->div); CLK_SET_RATE_PARENT, ff->mult, ff->div);
if (IS_ERR(clk)) { if (IS_ERR(clk)) {
pr_err("Failed to register clk %s: %ld\n", pr_err("Failed to register clk %s: %pe\n", ff->name, clk);
ff->name, PTR_ERR(clk));
continue; continue;
} }
...@@ -122,8 +120,7 @@ int mtk_clk_register_gates_with_dev(struct device_node *node, ...@@ -122,8 +120,7 @@ int mtk_clk_register_gates_with_dev(struct device_node *node,
regmap = device_node_to_regmap(node); regmap = device_node_to_regmap(node);
if (IS_ERR(regmap)) { if (IS_ERR(regmap)) {
pr_err("Cannot find regmap for %pOF: %ld\n", node, pr_err("Cannot find regmap for %pOF: %pe\n", node, regmap);
PTR_ERR(regmap));
return PTR_ERR(regmap); return PTR_ERR(regmap);
} }
...@@ -141,8 +138,7 @@ int mtk_clk_register_gates_with_dev(struct device_node *node, ...@@ -141,8 +138,7 @@ int mtk_clk_register_gates_with_dev(struct device_node *node,
gate->shift, gate->ops, gate->flags, dev); gate->shift, gate->ops, gate->flags, dev);
if (IS_ERR(clk)) { if (IS_ERR(clk)) {
pr_err("Failed to register clk %s: %ld\n", pr_err("Failed to register clk %s: %pe\n", gate->name, clk);
gate->name, PTR_ERR(clk));
continue; continue;
} }
...@@ -264,8 +260,7 @@ void mtk_clk_register_composites(const struct mtk_composite *mcs, ...@@ -264,8 +260,7 @@ void mtk_clk_register_composites(const struct mtk_composite *mcs,
clk = mtk_clk_register_composite(mc, base, lock); clk = mtk_clk_register_composite(mc, base, lock);
if (IS_ERR(clk)) { if (IS_ERR(clk)) {
pr_err("Failed to register clk %s: %ld\n", pr_err("Failed to register clk %s: %pe\n", mc->name, clk);
mc->name, PTR_ERR(clk));
continue; continue;
} }
...@@ -293,8 +288,7 @@ void mtk_clk_register_dividers(const struct mtk_clk_divider *mcds, ...@@ -293,8 +288,7 @@ void mtk_clk_register_dividers(const struct mtk_clk_divider *mcds,
mcd->div_width, mcd->clk_divider_flags, lock); mcd->div_width, mcd->clk_divider_flags, lock);
if (IS_ERR(clk)) { if (IS_ERR(clk)) {
pr_err("Failed to register clk %s: %ld\n", pr_err("Failed to register clk %s: %pe\n", mcd->name, clk);
mcd->name, PTR_ERR(clk));
continue; continue;
} }
......
...@@ -175,8 +175,7 @@ int mtk_clk_register_muxes(const struct mtk_mux *muxes, ...@@ -175,8 +175,7 @@ int mtk_clk_register_muxes(const struct mtk_mux *muxes,
regmap = device_node_to_regmap(node); regmap = device_node_to_regmap(node);
if (IS_ERR(regmap)) { if (IS_ERR(regmap)) {
pr_err("Cannot find regmap for %pOF: %ld\n", node, pr_err("Cannot find regmap for %pOF: %pe\n", node, regmap);
PTR_ERR(regmap));
return PTR_ERR(regmap); return PTR_ERR(regmap);
} }
...@@ -187,8 +186,7 @@ int mtk_clk_register_muxes(const struct mtk_mux *muxes, ...@@ -187,8 +186,7 @@ int mtk_clk_register_muxes(const struct mtk_mux *muxes,
clk = mtk_clk_register_mux(mux, regmap, lock); clk = mtk_clk_register_mux(mux, regmap, lock);
if (IS_ERR(clk)) { if (IS_ERR(clk)) {
pr_err("Failed to register clk %s: %ld\n", pr_err("Failed to register clk %s: %pe\n", mux->name, clk);
mux->name, PTR_ERR(clk));
continue; continue;
} }
......
...@@ -378,8 +378,7 @@ void mtk_clk_register_plls(struct device_node *node, ...@@ -378,8 +378,7 @@ void mtk_clk_register_plls(struct device_node *node,
clk = mtk_clk_register_pll(pll, base); clk = mtk_clk_register_pll(pll, base);
if (IS_ERR(clk)) { if (IS_ERR(clk)) {
pr_err("Failed to register clk %s: %ld\n", pr_err("Failed to register clk %s: %pe\n", pll->name, clk);
pll->name, PTR_ERR(clk));
continue; continue;
} }
......
...@@ -100,8 +100,7 @@ static void mtk_register_reset_controller_common(struct device_node *np, ...@@ -100,8 +100,7 @@ static void mtk_register_reset_controller_common(struct device_node *np,
regmap = device_node_to_regmap(np); regmap = device_node_to_regmap(np);
if (IS_ERR(regmap)) { if (IS_ERR(regmap)) {
pr_err("Cannot find regmap for %pOF: %ld\n", np, pr_err("Cannot find regmap for %pOF: %pe\n", np, regmap);
PTR_ERR(regmap));
return; return;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment