Commit 24243697 authored by Eugenio Pérez's avatar Eugenio Pérez Committed by Michael S. Tsirkin

vdpasim: allow to enable a vq repeatedly

Code must be resilient to enable a queue many times.

At the moment the queue is resetting so it's definitely not the expected
behavior.

v2: set vq->ready = 0 at disable.

Fixes: 2c53d0f6 ("vdpasim: vDPA device simulator")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarEugenio Pérez <eperezma@redhat.com>
Message-Id: <20220519145919.772896-1-eperezma@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Reviewed-by: default avatarStefano Garzarella <sgarzare@redhat.com>
parent ac33f84b
...@@ -364,11 +364,14 @@ static void vdpasim_set_vq_ready(struct vdpa_device *vdpa, u16 idx, bool ready) ...@@ -364,11 +364,14 @@ static void vdpasim_set_vq_ready(struct vdpa_device *vdpa, u16 idx, bool ready)
{ {
struct vdpasim *vdpasim = vdpa_to_sim(vdpa); struct vdpasim *vdpasim = vdpa_to_sim(vdpa);
struct vdpasim_virtqueue *vq = &vdpasim->vqs[idx]; struct vdpasim_virtqueue *vq = &vdpasim->vqs[idx];
bool old_ready;
spin_lock(&vdpasim->lock); spin_lock(&vdpasim->lock);
old_ready = vq->ready;
vq->ready = ready; vq->ready = ready;
if (vq->ready) if (vq->ready && !old_ready) {
vdpasim_queue_ready(vdpasim, idx); vdpasim_queue_ready(vdpasim, idx);
}
spin_unlock(&vdpasim->lock); spin_unlock(&vdpasim->lock);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment