Commit 248fb5b9 authored by Al Viro's avatar Al Viro

namei.c: take "jump to root" into a new helper

... and use it both in path_init() (for absolute pathnames) and
get_link() (for absolute symlinks).
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent ef55d917
...@@ -841,6 +841,26 @@ static inline void path_to_nameidata(const struct path *path, ...@@ -841,6 +841,26 @@ static inline void path_to_nameidata(const struct path *path,
nd->path.dentry = path->dentry; nd->path.dentry = path->dentry;
} }
static int nd_jump_root(struct nameidata *nd)
{
if (nd->flags & LOOKUP_RCU) {
struct dentry *d;
nd->path = nd->root;
d = nd->path.dentry;
nd->inode = d->d_inode;
nd->seq = nd->root_seq;
if (unlikely(read_seqcount_retry(&d->d_seq, nd->seq)))
return -ECHILD;
} else {
path_put(&nd->path);
nd->path = nd->root;
path_get(&nd->path);
nd->inode = nd->path.dentry->d_inode;
}
nd->flags |= LOOKUP_JUMPED;
return 0;
}
/* /*
* Helper to directly jump to a known parsed path from ->follow_link, * Helper to directly jump to a known parsed path from ->follow_link,
* caller must have taken a reference to path beforehand. * caller must have taken a reference to path beforehand.
...@@ -1017,21 +1037,8 @@ const char *get_link(struct nameidata *nd) ...@@ -1017,21 +1037,8 @@ const char *get_link(struct nameidata *nd)
if (*res == '/') { if (*res == '/') {
if (!nd->root.mnt) if (!nd->root.mnt)
set_root(nd); set_root(nd);
if (nd->flags & LOOKUP_RCU) { if (unlikely(nd_jump_root(nd)))
struct dentry *d; return ERR_PTR(-ECHILD);
nd->path = nd->root;
d = nd->path.dentry;
nd->inode = d->d_inode;
nd->seq = nd->root_seq;
if (unlikely(read_seqcount_retry(&d->d_seq, nd->seq)))
return ERR_PTR(-ECHILD);
} else {
path_put(&nd->path);
nd->path = nd->root;
path_get(&nd->root);
nd->inode = nd->path.dentry->d_inode;
}
nd->flags |= LOOKUP_JUMPED;
while (unlikely(*++res == '/')) while (unlikely(*++res == '/'))
; ;
} }
...@@ -2015,26 +2022,17 @@ static const char *path_init(struct nameidata *nd, unsigned flags) ...@@ -2015,26 +2022,17 @@ static const char *path_init(struct nameidata *nd, unsigned flags)
} }
nd->root.mnt = NULL; nd->root.mnt = NULL;
nd->path.mnt = NULL;
nd->path.dentry = NULL;
nd->m_seq = read_seqbegin(&mount_lock); nd->m_seq = read_seqbegin(&mount_lock);
if (*s == '/') { if (*s == '/') {
if (flags & LOOKUP_RCU) if (flags & LOOKUP_RCU)
rcu_read_lock(); rcu_read_lock();
set_root(nd); set_root(nd);
if (flags & LOOKUP_RCU) { if (likely(!nd_jump_root(nd)))
nd->seq = nd->root_seq;
nd->path = nd->root;
} else {
path_get(&nd->root);
nd->path = nd->root;
}
nd->inode = nd->path.dentry->d_inode;
if (!(flags & LOOKUP_RCU))
return s;
if (likely(!read_seqcount_retry(&nd->path.dentry->d_seq, nd->seq)))
return s; return s;
if (!(nd->flags & LOOKUP_ROOT)) nd->root.mnt = NULL;
nd->root.mnt = NULL;
rcu_read_unlock(); rcu_read_unlock();
return ERR_PTR(-ECHILD); return ERR_PTR(-ECHILD);
} else if (nd->dfd == AT_FDCWD) { } else if (nd->dfd == AT_FDCWD) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment