Commit 25729b0e authored by Artem Bityutskiy's avatar Artem Bityutskiy Committed by Al Viro

reiserfs: clean-up function return type

Turn 'reiserfs_flush_old_commits()' into a void function because the callers
do not cares about what it returns anyway.

We are going to remove the 'sb->s_dirt' field completely and this patch is a
small step towards this direction.
Signed-off-by: default avatarArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent efaa33eb
...@@ -3492,7 +3492,7 @@ static void flush_async_commits(struct work_struct *work) ...@@ -3492,7 +3492,7 @@ static void flush_async_commits(struct work_struct *work)
** flushes any old transactions to disk ** flushes any old transactions to disk
** ends the current transaction if it is too old ** ends the current transaction if it is too old
*/ */
int reiserfs_flush_old_commits(struct super_block *sb) void reiserfs_flush_old_commits(struct super_block *sb)
{ {
time_t now; time_t now;
struct reiserfs_transaction_handle th; struct reiserfs_transaction_handle th;
...@@ -3502,9 +3502,8 @@ int reiserfs_flush_old_commits(struct super_block *sb) ...@@ -3502,9 +3502,8 @@ int reiserfs_flush_old_commits(struct super_block *sb)
/* safety check so we don't flush while we are replaying the log during /* safety check so we don't flush while we are replaying the log during
* mount * mount
*/ */
if (list_empty(&journal->j_journal_list)) { if (list_empty(&journal->j_journal_list))
return 0; return;
}
/* check the current transaction. If there are no writers, and it is /* check the current transaction. If there are no writers, and it is
* too old, finish it, and force the commit blocks to disk * too old, finish it, and force the commit blocks to disk
...@@ -3526,7 +3525,6 @@ int reiserfs_flush_old_commits(struct super_block *sb) ...@@ -3526,7 +3525,6 @@ int reiserfs_flush_old_commits(struct super_block *sb)
do_journal_end(&th, sb, 1, COMMIT_NOW | WAIT); do_journal_end(&th, sb, 1, COMMIT_NOW | WAIT);
} }
} }
return sb->s_dirt;
} }
/* /*
......
...@@ -2452,7 +2452,7 @@ struct reiserfs_transaction_handle *reiserfs_persistent_transaction(struct ...@@ -2452,7 +2452,7 @@ struct reiserfs_transaction_handle *reiserfs_persistent_transaction(struct
int reiserfs_end_persistent_transaction(struct reiserfs_transaction_handle *); int reiserfs_end_persistent_transaction(struct reiserfs_transaction_handle *);
int reiserfs_commit_page(struct inode *inode, struct page *page, int reiserfs_commit_page(struct inode *inode, struct page *page,
unsigned from, unsigned to); unsigned from, unsigned to);
int reiserfs_flush_old_commits(struct super_block *); void reiserfs_flush_old_commits(struct super_block *);
int reiserfs_commit_for_inode(struct inode *); int reiserfs_commit_for_inode(struct inode *);
int reiserfs_inode_needs_commit(struct inode *); int reiserfs_inode_needs_commit(struct inode *);
void reiserfs_update_inode_transaction(struct inode *); void reiserfs_update_inode_transaction(struct inode *);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment