Commit 2594a57a authored by Linus Torvalds's avatar Linus Torvalds

Merge branch 'kmemcheck-for-linus' of...

Merge branch 'kmemcheck-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/penberg/slab-2.6

* 'kmemcheck-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/penberg/slab-2.6:
  kmemcheck: Test the full object in kmemcheck_is_obj_initialized()
parents f24407d2 6adad2d5
...@@ -337,7 +337,7 @@ bool kmemcheck_is_obj_initialized(unsigned long addr, size_t size) ...@@ -337,7 +337,7 @@ bool kmemcheck_is_obj_initialized(unsigned long addr, size_t size)
if (!shadow) if (!shadow)
return true; return true;
status = kmemcheck_shadow_test(shadow, size); status = kmemcheck_shadow_test_all(shadow, size);
return status == KMEMCHECK_SHADOW_INITIALIZED; return status == KMEMCHECK_SHADOW_INITIALIZED;
} }
......
...@@ -125,12 +125,12 @@ void kmemcheck_mark_initialized_pages(struct page *p, unsigned int n) ...@@ -125,12 +125,12 @@ void kmemcheck_mark_initialized_pages(struct page *p, unsigned int n)
enum kmemcheck_shadow kmemcheck_shadow_test(void *shadow, unsigned int size) enum kmemcheck_shadow kmemcheck_shadow_test(void *shadow, unsigned int size)
{ {
#ifdef CONFIG_KMEMCHECK_PARTIAL_OK
uint8_t *x; uint8_t *x;
unsigned int i; unsigned int i;
x = shadow; x = shadow;
#ifdef CONFIG_KMEMCHECK_PARTIAL_OK
/* /*
* Make sure _some_ bytes are initialized. Gcc frequently generates * Make sure _some_ bytes are initialized. Gcc frequently generates
* code to access neighboring bytes. * code to access neighboring bytes.
...@@ -139,13 +139,25 @@ enum kmemcheck_shadow kmemcheck_shadow_test(void *shadow, unsigned int size) ...@@ -139,13 +139,25 @@ enum kmemcheck_shadow kmemcheck_shadow_test(void *shadow, unsigned int size)
if (x[i] == KMEMCHECK_SHADOW_INITIALIZED) if (x[i] == KMEMCHECK_SHADOW_INITIALIZED)
return x[i]; return x[i];
} }
return x[0];
#else #else
return kmemcheck_shadow_test_all(shadow, size);
#endif
}
enum kmemcheck_shadow kmemcheck_shadow_test_all(void *shadow, unsigned int size)
{
uint8_t *x;
unsigned int i;
x = shadow;
/* All bytes must be initialized. */ /* All bytes must be initialized. */
for (i = 0; i < size; ++i) { for (i = 0; i < size; ++i) {
if (x[i] != KMEMCHECK_SHADOW_INITIALIZED) if (x[i] != KMEMCHECK_SHADOW_INITIALIZED)
return x[i]; return x[i];
} }
#endif
return x[0]; return x[0];
} }
......
...@@ -11,6 +11,8 @@ enum kmemcheck_shadow { ...@@ -11,6 +11,8 @@ enum kmemcheck_shadow {
void *kmemcheck_shadow_lookup(unsigned long address); void *kmemcheck_shadow_lookup(unsigned long address);
enum kmemcheck_shadow kmemcheck_shadow_test(void *shadow, unsigned int size); enum kmemcheck_shadow kmemcheck_shadow_test(void *shadow, unsigned int size);
enum kmemcheck_shadow kmemcheck_shadow_test_all(void *shadow,
unsigned int size);
void kmemcheck_shadow_set(void *shadow, unsigned int size); void kmemcheck_shadow_set(void *shadow, unsigned int size);
#endif #endif
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment