Commit 2625996b authored by Guenter Roeck's avatar Guenter Roeck

hwmon: (smsc47m192) Convert to use devm_ functions

Convert to use devm_ functions to reduce code size and simplify the code.
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Acked-by: default avatarJean Delvare <khali@linux-fr.org>
parent 08ad7c95
...@@ -554,11 +554,10 @@ static int smsc47m192_probe(struct i2c_client *client, ...@@ -554,11 +554,10 @@ static int smsc47m192_probe(struct i2c_client *client,
int config; int config;
int err; int err;
data = kzalloc(sizeof(struct smsc47m192_data), GFP_KERNEL); data = devm_kzalloc(&client->dev, sizeof(struct smsc47m192_data),
if (!data) { GFP_KERNEL);
err = -ENOMEM; if (!data)
goto exit; return -ENOMEM;
}
i2c_set_clientdata(client, data); i2c_set_clientdata(client, data);
data->vrm = vid_which_vrm(); data->vrm = vid_which_vrm();
...@@ -570,7 +569,7 @@ static int smsc47m192_probe(struct i2c_client *client, ...@@ -570,7 +569,7 @@ static int smsc47m192_probe(struct i2c_client *client,
/* Register sysfs hooks */ /* Register sysfs hooks */
err = sysfs_create_group(&client->dev.kobj, &smsc47m192_group); err = sysfs_create_group(&client->dev.kobj, &smsc47m192_group);
if (err) if (err)
goto exit_free; return err;
/* Pin 110 is either in4 (+12V) or VID4 */ /* Pin 110 is either in4 (+12V) or VID4 */
config = i2c_smbus_read_byte_data(client, SMSC47M192_REG_CONFIG); config = i2c_smbus_read_byte_data(client, SMSC47M192_REG_CONFIG);
...@@ -592,9 +591,6 @@ static int smsc47m192_probe(struct i2c_client *client, ...@@ -592,9 +591,6 @@ static int smsc47m192_probe(struct i2c_client *client,
exit_remove_files: exit_remove_files:
sysfs_remove_group(&client->dev.kobj, &smsc47m192_group); sysfs_remove_group(&client->dev.kobj, &smsc47m192_group);
sysfs_remove_group(&client->dev.kobj, &smsc47m192_group_in4); sysfs_remove_group(&client->dev.kobj, &smsc47m192_group_in4);
exit_free:
kfree(data);
exit:
return err; return err;
} }
...@@ -606,8 +602,6 @@ static int smsc47m192_remove(struct i2c_client *client) ...@@ -606,8 +602,6 @@ static int smsc47m192_remove(struct i2c_client *client)
sysfs_remove_group(&client->dev.kobj, &smsc47m192_group); sysfs_remove_group(&client->dev.kobj, &smsc47m192_group);
sysfs_remove_group(&client->dev.kobj, &smsc47m192_group_in4); sysfs_remove_group(&client->dev.kobj, &smsc47m192_group_in4);
kfree(data);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment