Commit 268ae31b authored by William Lee Irwin III's avatar William Lee Irwin III Committed by Linus Torvalds

[PATCH] fix isofs ignoring noexec and mode mount options

 * Removed period check for executables in fs/isofs/inode.c
This fixes Debian BTS #162190
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=162190

	From: Jan Gregor <gregor_jan@seznam.cz>
	To: Debian Bug Tracking System <submit@bugs.debian.org>
	Subject: kernel-source-2.4.18: kernel ignores noexec and mode option in cdrom case
	Message-ID: <20020924162129.A328@pisidlo>

In /etc/fstab i have following line:
/dev/cdrom      /cdrom          iso9660  gid=100,noauto,ro,noexec,mode=0444,user      0       0

I found on one CD that some files have exec bit set. From brief view
those files has no extension (filename.ext).

My drive is asus-1610a (ATAPI writer) connected throught scsi-emulation.
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 3b4cef9e
......@@ -1247,14 +1247,6 @@ static void isofs_read_inode(struct inode * inode)
inode->i_mode = sbi->s_mode;
inode->i_nlink = 1;
inode->i_mode |= S_IFREG;
/* If there are no periods in the name,
* then set the execute permission bit
*/
for(i=0; i< de->name_len[0]; i++)
if(de->name[i]=='.' || de->name[i]==';')
break;
if(i == de->name_len[0] || de->name[i] == ';')
inode->i_mode |= S_IXUGO; /* execute permission */
}
inode->i_uid = sbi->s_uid;
inode->i_gid = sbi->s_gid;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment