Commit 2778caed authored by Jean Delvare's avatar Jean Delvare Committed by Matthias Brugger

soc: mediatek: Let PMIC Wrapper and SCPSYS depend on OF

With the following configuration options:
CONFIG_OF is not set
CONFIG_MTK_PMIC_WRAP=y
CONFIG_MTK_SCPSYS=y
we get the following build warnings:

  CC      drivers/soc/mediatek/mtk-pmic-wrap.o
drivers/soc/mediatek/mtk-pmic-wrap.c:2138:34: warning: ‘of_pwrap_match_tbl’ defined but not used [-Wunused-const-variable=]
drivers/soc/mediatek/mtk-pmic-wrap.c:1953:34: warning: ‘of_slave_match_tbl’ defined but not used [-Wunused-const-variable=]
  CC      drivers/soc/mediatek/mtk-scpsys.o
drivers/soc/mediatek/mtk-scpsys.c:1084:34: warning: ‘of_scpsys_match_tbl’ defined but not used [-Wunused-const-variable=]

Looking at the code, both drivers can only bind to OF-defined device
nodes, so these drivers are useless without OF and should therefore
depend on it.

Also drop of_match_ptr() from both drivers. We already know what it
will resolve to, so we might as well save cpp some work.

Developers or QA teams who wish to test-build the code can still do
so by enabling CONFIG_OF, which is available on all architectures and
has no dependencies.
Signed-off-by: default avatarJean Delvare <jdelvare@suse.de>
Reported-by: default avatarkernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/all/202207240252.ZY5hSCNB-lkp@intel.com/
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Chenglin Xu <chenglin.xu@mediatek.com>
Link: https://lore.kernel.org/r/20220730144833.0a0d9825@endymion.delvareSigned-off-by: default avatarMatthias Brugger <matthias.bgg@gmail.com>
parent 568035b0
...@@ -37,6 +37,7 @@ config MTK_INFRACFG ...@@ -37,6 +37,7 @@ config MTK_INFRACFG
config MTK_PMIC_WRAP config MTK_PMIC_WRAP
tristate "MediaTek PMIC Wrapper Support" tristate "MediaTek PMIC Wrapper Support"
depends on RESET_CONTROLLER depends on RESET_CONTROLLER
depends on OF
select REGMAP select REGMAP
help help
Say yes here to add support for MediaTek PMIC Wrapper found Say yes here to add support for MediaTek PMIC Wrapper found
...@@ -46,6 +47,7 @@ config MTK_PMIC_WRAP ...@@ -46,6 +47,7 @@ config MTK_PMIC_WRAP
config MTK_SCPSYS config MTK_SCPSYS
bool "MediaTek SCPSYS Support" bool "MediaTek SCPSYS Support"
default ARCH_MEDIATEK default ARCH_MEDIATEK
depends on OF
select REGMAP select REGMAP
select MTK_INFRACFG select MTK_INFRACFG
select PM_GENERIC_DOMAINS if PM select PM_GENERIC_DOMAINS if PM
......
...@@ -2316,7 +2316,7 @@ static int pwrap_probe(struct platform_device *pdev) ...@@ -2316,7 +2316,7 @@ static int pwrap_probe(struct platform_device *pdev)
static struct platform_driver pwrap_drv = { static struct platform_driver pwrap_drv = {
.driver = { .driver = {
.name = "mt-pmic-pwrap", .name = "mt-pmic-pwrap",
.of_match_table = of_match_ptr(of_pwrap_match_tbl), .of_match_table = of_pwrap_match_tbl,
}, },
.probe = pwrap_probe, .probe = pwrap_probe,
}; };
......
...@@ -1141,7 +1141,7 @@ static struct platform_driver scpsys_drv = { ...@@ -1141,7 +1141,7 @@ static struct platform_driver scpsys_drv = {
.name = "mtk-scpsys", .name = "mtk-scpsys",
.suppress_bind_attrs = true, .suppress_bind_attrs = true,
.owner = THIS_MODULE, .owner = THIS_MODULE,
.of_match_table = of_match_ptr(of_scpsys_match_tbl), .of_match_table = of_scpsys_match_tbl,
}, },
}; };
builtin_platform_driver(scpsys_drv); builtin_platform_driver(scpsys_drv);
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment