Commit 2791c1f9 authored by Mike Miller's avatar Mike Miller Committed by Linus Torvalds

[PATCH] cciss: pdev->intr fix

This patch fixes our usage of pdev->intr.  We were truncating it to an unchar.
 We were also reading it before calling pci_enable_device.  This patch fixes
both of those.  Thanks to Bjorn Helgaas for the patch.
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent a1466ae2
...@@ -2300,7 +2300,6 @@ static int find_PCI_BAR_index(struct pci_dev *pdev, ...@@ -2300,7 +2300,6 @@ static int find_PCI_BAR_index(struct pci_dev *pdev,
static int cciss_pci_init(ctlr_info_t *c, struct pci_dev *pdev) static int cciss_pci_init(ctlr_info_t *c, struct pci_dev *pdev)
{ {
ushort subsystem_vendor_id, subsystem_device_id, command; ushort subsystem_vendor_id, subsystem_device_id, command;
unchar irq = pdev->irq;
__u32 board_id, scratchpad = 0; __u32 board_id, scratchpad = 0;
__u64 cfg_offset; __u64 cfg_offset;
__u32 cfg_base_addr; __u32 cfg_base_addr;
...@@ -2359,11 +2358,11 @@ static int cciss_pci_init(ctlr_info_t *c, struct pci_dev *pdev) ...@@ -2359,11 +2358,11 @@ static int cciss_pci_init(ctlr_info_t *c, struct pci_dev *pdev)
#ifdef CCISS_DEBUG #ifdef CCISS_DEBUG
printk("command = %x\n", command); printk("command = %x\n", command);
printk("irq = %x\n", irq); printk("irq = %x\n", pdev->irq);
printk("board_id = %x\n", board_id); printk("board_id = %x\n", board_id);
#endif /* CCISS_DEBUG */ #endif /* CCISS_DEBUG */
c->intr = irq; c->intr = pdev->irq;
/* /*
* Memory base addr is first addr , the second points to the config * Memory base addr is first addr , the second points to the config
......
...@@ -48,7 +48,7 @@ struct ctlr_info ...@@ -48,7 +48,7 @@ struct ctlr_info
unsigned long io_mem_addr; unsigned long io_mem_addr;
unsigned long io_mem_length; unsigned long io_mem_length;
CfgTable_struct *cfgtable; CfgTable_struct *cfgtable;
int intr; unsigned int intr;
int interrupts_enabled; int interrupts_enabled;
int max_commands; int max_commands;
int commands_outstanding; int commands_outstanding;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment