Commit 27f7fcae authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

staging: vchiq: delete obselete comment

This comment describes a security problem which was fixed in commit
1c954540 ("staging: vchiq: avoid mixing kernel and user pointers").
The bug is fixed now so the FIXME can be removed.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/X/RnUjY3XkZohk7w@mwandaSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6500966d
...@@ -999,13 +999,6 @@ static int vchiq_irq_queue_bulk_tx_rx(struct vchiq_instance *instance, ...@@ -999,13 +999,6 @@ static int vchiq_irq_queue_bulk_tx_rx(struct vchiq_instance *instance,
userdata = &waiter->bulk_waiter; userdata = &waiter->bulk_waiter;
} }
/*
* FIXME address space mismatch:
* args->data may be interpreted as a kernel pointer
* in create_pagelist() called from vchiq_bulk_transfer(),
* accessing kernel data instead of user space, based on the
* address.
*/
status = vchiq_bulk_transfer(args->handle, NULL, args->data, args->size, status = vchiq_bulk_transfer(args->handle, NULL, args->data, args->size,
userdata, args->mode, dir); userdata, args->mode, dir);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment