Commit 28cf7559 authored by Zhang Yi's avatar Zhang Yi Committed by Andrew Morton

ext2: replace bh_submit_read() helper with bh_read()

bh_submit_read() and the uptodate check logic in bh_uptodate_or_lock()
has been integrated in bh_read() helper, so switch to use it directly.

Link: https://lkml.kernel.org/r/20220901133505.2510834-14-yi.zhang@huawei.comSigned-off-by: default avatarZhang Yi <yi.zhang@huawei.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 79f59784
...@@ -126,6 +126,7 @@ read_block_bitmap(struct super_block *sb, unsigned int block_group) ...@@ -126,6 +126,7 @@ read_block_bitmap(struct super_block *sb, unsigned int block_group)
struct ext2_group_desc * desc; struct ext2_group_desc * desc;
struct buffer_head * bh = NULL; struct buffer_head * bh = NULL;
ext2_fsblk_t bitmap_blk; ext2_fsblk_t bitmap_blk;
int ret;
desc = ext2_get_group_desc(sb, block_group, NULL); desc = ext2_get_group_desc(sb, block_group, NULL);
if (!desc) if (!desc)
...@@ -139,10 +140,10 @@ read_block_bitmap(struct super_block *sb, unsigned int block_group) ...@@ -139,10 +140,10 @@ read_block_bitmap(struct super_block *sb, unsigned int block_group)
block_group, le32_to_cpu(desc->bg_block_bitmap)); block_group, le32_to_cpu(desc->bg_block_bitmap));
return NULL; return NULL;
} }
if (likely(bh_uptodate_or_lock(bh))) ret = bh_read(bh, 0);
if (ret > 0)
return bh; return bh;
if (ret < 0) {
if (bh_submit_read(bh) < 0) {
brelse(bh); brelse(bh);
ext2_error(sb, __func__, ext2_error(sb, __func__,
"Cannot read block bitmap - " "Cannot read block bitmap - "
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment