Commit 295fd233 authored by John Garry's avatar John Garry Committed by Martin K. Petersen

scsi: hisi_sas: Use sas_task_find_rq()

Use sas_task_find_rq() to lookup the request per task for its driver tag.
Signed-off-by: default avatarJohn Garry <john.garry@huawei.com>
Link: https://lore.kernel.org/r/1666091763-11023-3-git-send-email-john.garry@huawei.comReviewed-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent a9ee3f84
...@@ -177,13 +177,13 @@ static void hisi_sas_slot_index_set(struct hisi_hba *hisi_hba, int slot_idx) ...@@ -177,13 +177,13 @@ static void hisi_sas_slot_index_set(struct hisi_hba *hisi_hba, int slot_idx)
} }
static int hisi_sas_slot_index_alloc(struct hisi_hba *hisi_hba, static int hisi_sas_slot_index_alloc(struct hisi_hba *hisi_hba,
struct scsi_cmnd *scsi_cmnd) struct request *rq)
{ {
int index; int index;
void *bitmap = hisi_hba->slot_index_tags; void *bitmap = hisi_hba->slot_index_tags;
if (scsi_cmnd) if (rq)
return scsi_cmd_to_rq(scsi_cmnd)->tag; return rq->tag;
spin_lock(&hisi_hba->lock); spin_lock(&hisi_hba->lock);
index = find_next_zero_bit(bitmap, hisi_hba->slot_index_count, index = find_next_zero_bit(bitmap, hisi_hba->slot_index_count,
...@@ -461,11 +461,11 @@ static int hisi_sas_queue_command(struct sas_task *task, gfp_t gfp_flags) ...@@ -461,11 +461,11 @@ static int hisi_sas_queue_command(struct sas_task *task, gfp_t gfp_flags)
struct asd_sas_port *sas_port = device->port; struct asd_sas_port *sas_port = device->port;
struct hisi_sas_device *sas_dev = device->lldd_dev; struct hisi_sas_device *sas_dev = device->lldd_dev;
bool internal_abort = sas_is_internal_abort(task); bool internal_abort = sas_is_internal_abort(task);
struct scsi_cmnd *scmd = NULL;
struct hisi_sas_dq *dq = NULL; struct hisi_sas_dq *dq = NULL;
struct hisi_sas_port *port; struct hisi_sas_port *port;
struct hisi_hba *hisi_hba; struct hisi_hba *hisi_hba;
struct hisi_sas_slot *slot; struct hisi_sas_slot *slot;
struct request *rq = NULL;
struct device *dev; struct device *dev;
int rc; int rc;
...@@ -520,22 +520,12 @@ static int hisi_sas_queue_command(struct sas_task *task, gfp_t gfp_flags) ...@@ -520,22 +520,12 @@ static int hisi_sas_queue_command(struct sas_task *task, gfp_t gfp_flags)
return -ECOMM; return -ECOMM;
} }
if (task->uldd_task) { rq = sas_task_find_rq(task);
struct ata_queued_cmd *qc; if (rq) {
if (dev_is_sata(device)) {
qc = task->uldd_task;
scmd = qc->scsicmd;
} else {
scmd = task->uldd_task;
}
}
if (scmd) {
unsigned int dq_index; unsigned int dq_index;
u32 blk_tag; u32 blk_tag;
blk_tag = blk_mq_unique_tag(scsi_cmd_to_rq(scmd)); blk_tag = blk_mq_unique_tag(rq);
dq_index = blk_mq_unique_tag_to_hwq(blk_tag); dq_index = blk_mq_unique_tag_to_hwq(blk_tag);
dq = &hisi_hba->dq[dq_index]; dq = &hisi_hba->dq[dq_index];
} else { } else {
...@@ -580,7 +570,7 @@ static int hisi_sas_queue_command(struct sas_task *task, gfp_t gfp_flags) ...@@ -580,7 +570,7 @@ static int hisi_sas_queue_command(struct sas_task *task, gfp_t gfp_flags)
if (!internal_abort && hisi_hba->hw->slot_index_alloc) if (!internal_abort && hisi_hba->hw->slot_index_alloc)
rc = hisi_hba->hw->slot_index_alloc(hisi_hba, device); rc = hisi_hba->hw->slot_index_alloc(hisi_hba, device);
else else
rc = hisi_sas_slot_index_alloc(hisi_hba, scmd); rc = hisi_sas_slot_index_alloc(hisi_hba, rq);
if (rc < 0) if (rc < 0)
goto err_out_dif_dma_unmap; goto err_out_dif_dma_unmap;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment