Commit 2979d7e9 authored by kbuild test robot's avatar kbuild test robot Committed by Alex Deucher

drm/amd/display: fix ifnullfree.cocci warnings

drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/gpio_service.c:134:3-8: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/gpio_service.c:175:4-9: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Fixes: f09cd1f46388 ("drm/amd/display: Use kernel alloc/free")
Signed-off-by: default avatarFengguang Wu <fengguang.wu@intel.com>
Reviewed-by: default avatarHarry Wentland <harry.wentland@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 1a7e4f74
...@@ -130,8 +130,7 @@ struct gpio_service *dal_gpio_service_create( ...@@ -130,8 +130,7 @@ struct gpio_service *dal_gpio_service_create(
slot = service->busyness[index_of_id]; slot = service->busyness[index_of_id];
if (slot) kfree(slot);
kfree(slot);
} }
failure_1: failure_1:
...@@ -171,8 +170,7 @@ void dal_gpio_service_destroy( ...@@ -171,8 +170,7 @@ void dal_gpio_service_destroy(
do { do {
uint32_t *slot = (*ptr)->busyness[index_of_id]; uint32_t *slot = (*ptr)->busyness[index_of_id];
if (slot) kfree(slot);
kfree(slot);
++index_of_id; ++index_of_id;
} while (index_of_id < GPIO_ID_COUNT); } while (index_of_id < GPIO_ID_COUNT);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment