Commit 29935554 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Dave Airlie

drm: Disallow DRM_IOCTL_MODESET_CTL for KMS drivers

DRM_IOCTL_MODESET_CTL must only be used for UMS drivers. Make it a no-op
for KMS drivers.
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: default avatarMichel Dänzer <michel@daenzer.net>
Signed-off-by: default avatarDave Airlie <airlied@gmail.com>
parent faadaf97
...@@ -974,7 +974,6 @@ EXPORT_SYMBOL(drm_vblank_off); ...@@ -974,7 +974,6 @@ EXPORT_SYMBOL(drm_vblank_off);
* drm_vblank_pre_modeset - account for vblanks across mode sets * drm_vblank_pre_modeset - account for vblanks across mode sets
* @dev: DRM device * @dev: DRM device
* @crtc: CRTC in question * @crtc: CRTC in question
* @post: post or pre mode set?
* *
* Account for vblank events across mode setting events, which will likely * Account for vblank events across mode setting events, which will likely
* reset the hardware frame counter. * reset the hardware frame counter.
...@@ -1037,6 +1036,10 @@ int drm_modeset_ctl(struct drm_device *dev, void *data, ...@@ -1037,6 +1036,10 @@ int drm_modeset_ctl(struct drm_device *dev, void *data,
if (!dev->num_crtcs) if (!dev->num_crtcs)
return 0; return 0;
/* KMS drivers handle this internally */
if (drm_core_check_feature(dev, DRIVER_MODESET))
return 0;
crtc = modeset->crtc; crtc = modeset->crtc;
if (crtc >= dev->num_crtcs) if (crtc >= dev->num_crtcs)
return -EINVAL; return -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment