Commit 29bd4267 authored by Nicolas Dufresne's avatar Nicolas Dufresne Committed by Mauro Carvalho Chehab

media: hantro: Fix JPEG encoder ENUM_FRMSIZE on RK3399

Since 79c987de, enumerating framesize on format set with "MODE_NONE"
(any raw formats) is reporting an invalid frmsize.

  Size: Stepwise 0x0 - 0x0 with step 0/0

Before this change, the driver would return EINVAL, which is also invalid
but worked in GStreamer. The original intent was not to implement it, hence
the -ENOTTY return in this change. While drivers should implement
ENUM_FRMSIZE for all formats and queues, this change is limited in scope to
fix the regression.

This fixes taking picture in Gnome Cheese software, or any software using
GSteamer to encode JPEG with hardware acceleration.

Fixes: 79c987de ("media: hantro: Use post processor scaling capacities")
Reported-by: default avatarRobert Mader <robert.mader@collabora.com>
Signed-off-by: default avatarNicolas Dufresne <nicolas.dufresne@collabora.com>
Reviewed-by: default avatarBenjamin Gaignard <benjamin.gaignard@collabora.com>
Reviewed-by: default avatarEzequiel Garcia <ezequiel@vanguardiasur.com.ar>
Tested-by: default avatarRobert Mader <robert.mader@collabora.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 637046bb
...@@ -161,8 +161,11 @@ static int vidioc_enum_framesizes(struct file *file, void *priv, ...@@ -161,8 +161,11 @@ static int vidioc_enum_framesizes(struct file *file, void *priv,
} }
/* For non-coded formats check if postprocessing scaling is possible */ /* For non-coded formats check if postprocessing scaling is possible */
if (fmt->codec_mode == HANTRO_MODE_NONE && hantro_needs_postproc(ctx, fmt)) { if (fmt->codec_mode == HANTRO_MODE_NONE) {
return hanto_postproc_enum_framesizes(ctx, fsize); if (hantro_needs_postproc(ctx, fmt))
return hanto_postproc_enum_framesizes(ctx, fsize);
else
return -ENOTTY;
} else if (fsize->index != 0) { } else if (fsize->index != 0) {
vpu_debug(0, "invalid frame size index (expected 0, got %d)\n", vpu_debug(0, "invalid frame size index (expected 0, got %d)\n",
fsize->index); fsize->index);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment