Commit 2a4ee7ee authored by Tomi Valkeinen's avatar Tomi Valkeinen

OMAPDSS: APPLY: add return value to dss_mgr_enable()

Now that dss_mgr_enable() can fail due to checks, make it return the
error value.
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent 39518356
...@@ -967,7 +967,7 @@ static void dss_mgr_setup_fifos(struct omap_overlay_manager *mgr) ...@@ -967,7 +967,7 @@ static void dss_mgr_setup_fifos(struct omap_overlay_manager *mgr)
} }
} }
void dss_mgr_enable(struct omap_overlay_manager *mgr) int dss_mgr_enable(struct omap_overlay_manager *mgr)
{ {
struct mgr_priv_data *mp = get_mgr_priv(mgr); struct mgr_priv_data *mp = get_mgr_priv(mgr);
unsigned long flags; unsigned long flags;
...@@ -986,8 +986,7 @@ void dss_mgr_enable(struct omap_overlay_manager *mgr) ...@@ -986,8 +986,7 @@ void dss_mgr_enable(struct omap_overlay_manager *mgr)
if (r) { if (r) {
DSSERR("failed to enable manager %d: check_settings failed\n", DSSERR("failed to enable manager %d: check_settings failed\n",
mgr->id); mgr->id);
spin_unlock_irqrestore(&data_lock, flags); goto err;
goto out;
} }
mp->enabled = true; mp->enabled = true;
...@@ -1006,6 +1005,13 @@ void dss_mgr_enable(struct omap_overlay_manager *mgr) ...@@ -1006,6 +1005,13 @@ void dss_mgr_enable(struct omap_overlay_manager *mgr)
out: out:
mutex_unlock(&apply_lock); mutex_unlock(&apply_lock);
return 0;
err:
spin_unlock_irqrestore(&data_lock, flags);
mutex_unlock(&apply_lock);
return r;
} }
void dss_mgr_disable(struct omap_overlay_manager *mgr) void dss_mgr_disable(struct omap_overlay_manager *mgr)
......
...@@ -170,7 +170,7 @@ int dss_mgr_wait_for_go_ovl(struct omap_overlay *ovl); ...@@ -170,7 +170,7 @@ int dss_mgr_wait_for_go_ovl(struct omap_overlay *ovl);
void dss_mgr_start_update(struct omap_overlay_manager *mgr); void dss_mgr_start_update(struct omap_overlay_manager *mgr);
int omap_dss_mgr_apply(struct omap_overlay_manager *mgr); int omap_dss_mgr_apply(struct omap_overlay_manager *mgr);
void dss_mgr_enable(struct omap_overlay_manager *mgr); int dss_mgr_enable(struct omap_overlay_manager *mgr);
void dss_mgr_disable(struct omap_overlay_manager *mgr); void dss_mgr_disable(struct omap_overlay_manager *mgr);
int dss_mgr_set_info(struct omap_overlay_manager *mgr, int dss_mgr_set_info(struct omap_overlay_manager *mgr,
struct omap_overlay_manager_info *info); struct omap_overlay_manager_info *info);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment