Commit 2a540015 authored by Roland Dreier's avatar Roland Dreier Committed by Greg Kroah-Hartman

target: Don't set WBUS16 or SYNC bits in INQUIRY response

commit effc6cc8 upstream.

SPC-4 says about the WBUS16 and SYNC bits:

    The meanings of these fields are specific to SPI-5 (see 6.4.3).
    For SCSI transport protocols other than the SCSI Parallel
    Interface, these fields are reserved.

We don't have a SPI fabric module, so we should never set these bits.
(The comment was misleading, since it only mentioned Sync but the
actual code set WBUS16 too).
Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 17ec4b6b
......@@ -106,7 +106,7 @@ target_emulate_inquiry_std(struct se_cmd *cmd)
return 0;
}
buf[7] = 0x32; /* Sync=1 and CmdQue=1 */
buf[7] = 0x2; /* CmdQue=1 */
/*
* Do not include vendor, product, reversion info in INQUIRY
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment