Commit 2a65f7e2 authored by Wei Yongjun's avatar Wei Yongjun Committed by Daniel Lezcano

clocksource/drivers/ingenic_ost: Fix return value check in ingenic_ost_probe()

In case of error, the function device_node_to_regmap() returns
ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().

Fixes: ca7b72b5 ("clocksource: Add driver for the Ingenic JZ47xx OST")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210308123031.2285083-1-weiyongjun1@huawei.com
parent ac4daf73
...@@ -88,9 +88,9 @@ static int __init ingenic_ost_probe(struct platform_device *pdev) ...@@ -88,9 +88,9 @@ static int __init ingenic_ost_probe(struct platform_device *pdev)
return PTR_ERR(ost->regs); return PTR_ERR(ost->regs);
map = device_node_to_regmap(dev->parent->of_node); map = device_node_to_regmap(dev->parent->of_node);
if (!map) { if (IS_ERR(map)) {
dev_err(dev, "regmap not found"); dev_err(dev, "regmap not found");
return -EINVAL; return PTR_ERR(map);
} }
ost->clk = devm_clk_get(dev, "ost"); ost->clk = devm_clk_get(dev, "ost");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment