Commit 2ab0c6c5 authored by Julia Lawall's avatar Julia Lawall Committed by Guenter Roeck

hwmon: (core) use permission-specific DEVICE_ATTR variants

Use DEVICE_ATTR_RO for read-only attributes. This simplifies the source
code, improves readbility, and reduces the chance of inconsistencies.

The conversion was done automatically using coccinelle. It was validated
by compiling both the old and the new source code and comparing its text,
data, and bss size.
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
[groeck: Updated description]
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent c490c63e
...@@ -63,11 +63,11 @@ struct hwmon_thermal_data { ...@@ -63,11 +63,11 @@ struct hwmon_thermal_data {
}; };
static ssize_t static ssize_t
show_name(struct device *dev, struct device_attribute *attr, char *buf) name_show(struct device *dev, struct device_attribute *attr, char *buf)
{ {
return sprintf(buf, "%s\n", to_hwmon_device(dev)->name); return sprintf(buf, "%s\n", to_hwmon_device(dev)->name);
} }
static DEVICE_ATTR(name, S_IRUGO, show_name, NULL); static DEVICE_ATTR_RO(name);
static struct attribute *hwmon_dev_attrs[] = { static struct attribute *hwmon_dev_attrs[] = {
&dev_attr_name.attr, &dev_attr_name.attr,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment